[Security Solution][Endpoint] changes to Endpoint metadata API in support of space awareness #193490
+726
−786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int-list-details-space-aware
…w SavedObjectsClientFactory
paul-tavares
added
release_note:skip
…int-list-details-space-aware
…nd add savedObject client factory
…simplify method call signatures
|
/ci |
…int-list-details-space-aware
|
/ci |
|
/ci |
…ils-space-aware' into task/olm-8538-endpoint-list-details-space-aware
opauloh
approved these changes
Sep 25, 2024
tomsonpl
approved these changes
Sep 26, 2024
| registerListsServerExtension?: ListsServerExtensionRegistrar; | ||
| licenseService: LicenseService; | ||
| exceptionListsClient: ExceptionListClient | undefined; | ||
| cases: CasesServerStart | undefined; | ||
| featureUsageService: FeatureUsageService; | ||
| experimentalFeatures: ExperimentalFeatures; | ||
| messageSigningService: MessageSigningServiceInterface | undefined; | ||
| /** An internal ES client */ | ||
| esClient: ElasticsearchClient; |
There was a problem hiding this comment.
Can the name specify that it's an internal ES client?
There was a problem hiding this comment.
I rather keep it as is, since its consistent with how we normally name the ES client variables through out our code base. Is that cool with you?
| private getFleetAuthzService(): FleetStartContract['authz'] { | ||
| if (!this.startDependencies?.fleetAuthzService) { | ||
| if (!this.startDependencies?.fleetStartServices) { |
There was a problem hiding this comment.
should we also check for .authz , or not necessary?
There was a problem hiding this comment.
Its not necessary
| fleetServices = endpointContextStartContract.endpointFleetServicesFactory.asInternalUser(); | ||
| fleetServices = mockedFleetServices.service.asInternalUser(); | ||
| logger = loggingSystemMock.createLogger(); | ||
| productFeatureService = createProductFeaturesServiceMock( |
There was a problem hiding this comment.
do you think we could refactor createProductFeaturesServiceMock to accept an object, instead of multiple arguments where some of them are passed as undefined ?
There was a problem hiding this comment.
I'm ok either way... but perhaps if you feel we should, lets address it in a separate PR
| productFeaturesService, | ||
| } = this.startDependencies; | ||
| const endpointMetadataService = this.getEndpointMetadataService(); | ||
| const soClient = this.savedObjects.createInternalScopedSoClient(undefined, false); |
There was a problem hiding this comment.
what do you think about changing createInternalScopedSoClient to accept an object, instead of undefined passing undefined to get a default value?
There was a problem hiding this comment.
yeah, I can do that. Will push through a change soon
| @@ -41,35 +55,13 @@ export class EndpointFleetServicesFactory implements EndpointFleetServicesFactor | |||
| return { | |||
| agent: agentService.asInternalUser, | |||
| agentPolicy, | |||
|
|
|||
There was a problem hiding this comment.
yeah, it was... more for readability in separating related services
szwarckonrad
approved these changes
Sep 26, 2024
…ils-space-aware' into task/olm-8538-endpoint-list-details-space-aware
…int-list-details-space-aware
paul-tavares
added
backport:prev-minor
angorayc
approved these changes
Sep 26, 2024
jpdjere
approved these changes
Sep 26, 2024
…int-list-details-space-aware # Conflicts: # x-pack/plugins/security_solution/server/endpoint/endpoint_app_context_services.ts # x-pack/plugins/security_solution/server/endpoint/mocks/mocks.ts # x-pack/plugins/security_solution/server/plugin.ts
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Public APIs missing exports
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x |
paul-tavares
deleted the
task/olm-8538-endpoint-list-details-space-aware
branch
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Sep 27, 2024
…port of space awareness (elastic#193490) ## Summary ### Fleet Plugin - Added some mocks and updates others ### Security Solution The following refactoring changes were done in preparation for forthcoming work for supporting kibana spaces: - A new saved objects client factory service was introduced for use in `EndpointAppContextServices` - Deleted older saved objects client utilities - Simplified the list of options passed to `EndpointAppContextService#start()` method - Updated `EndpiontFleetServicesFactory` with: - simpler list of constructor arguments - changed members of object return by `asInternalUser()` - Refactored the `EndpintMetadataService` to: - take in simplified constructor arguments - Simplified most methods of the class with removal all ES Client, SO Client or Fleet services arguments from class method calling signatures. These are not provided to the service class upon initialization and can be accessed internally by the methods - Updates to Mocks and tests to reflect the above changes (cherry picked from commit 0b1e9f4) # Conflicts: # x-pack/plugins/security_solution/tsconfig.json
paul-tavares
added a commit
that referenced
this pull request
Sep 27, 2024
…in support of space awareness (#193490) (#194309) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Endpoint] changes to Endpoint metadata API in support of space awareness (#193490)](#193490) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paul Tavares","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T14:38:17Z","message":"[Security Solution][Endpoint] changes to Endpoint metadata API in support of space awareness (#193490)\n\n## Summary\r\n\r\n### Fleet Plugin\r\n\r\n- Added some mocks and updates others\r\n\r\n\r\n### Security Solution\r\n\r\nThe following refactoring changes were done in preparation for\r\nforthcoming work for supporting kibana spaces:\r\n\r\n- A new saved objects client factory service was introduced for use in\r\n`EndpointAppContextServices`\r\n- Deleted older saved objects client utilities\r\n- Simplified the list of options passed to\r\n`EndpointAppContextService#start()` method\r\n- Updated `EndpiontFleetServicesFactory` with:\r\n - simpler list of constructor arguments\r\n - changed members of object return by `asInternalUser()`\r\n- Refactored the `EndpintMetadataService` to:\r\n - take in simplified constructor arguments\r\n- Simplified most methods of the class with removal all ES Client, SO\r\nClient or Fleet services arguments from class method calling signatures.\r\nThese are not provided to the service class upon initialization and can\r\nbe accessed internally by the methods\r\n- Updates to Mocks and tests to reflect the above changes","sha":"0b1e9f475440d60260203ce2a85c8b57c4363130","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend Workflows","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review","v8.16.0"],"number":193490,"url":"https://github.com/elastic/kibana/pull/193490","mergeCommit":{"message":"[Security Solution][Endpoint] changes to Endpoint metadata API in support of space awareness (#193490)\n\n## Summary\r\n\r\n### Fleet Plugin\r\n\r\n- Added some mocks and updates others\r\n\r\n\r\n### Security Solution\r\n\r\nThe following refactoring changes were done in preparation for\r\nforthcoming work for supporting kibana spaces:\r\n\r\n- A new saved objects client factory service was introduced for use in\r\n`EndpointAppContextServices`\r\n- Deleted older saved objects client utilities\r\n- Simplified the list of options passed to\r\n`EndpointAppContextService#start()` method\r\n- Updated `EndpiontFleetServicesFactory` with:\r\n - simpler list of constructor arguments\r\n - changed members of object return by `asInternalUser()`\r\n- Refactored the `EndpintMetadataService` to:\r\n - take in simplified constructor arguments\r\n- Simplified most methods of the class with removal all ES Client, SO\r\nClient or Fleet services arguments from class method calling signatures.\r\nThese are not provided to the service class upon initialization and can\r\nbe accessed internally by the methods\r\n- Updates to Mocks and tests to reflect the above changes","sha":"0b1e9f475440d60260203ce2a85c8b57c4363130"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193490","number":193490,"mergeCommit":{"message":"[Security Solution][Endpoint] changes to Endpoint metadata API in support of space awareness (#193490)\n\n## Summary\r\n\r\n### Fleet Plugin\r\n\r\n- Added some mocks and updates others\r\n\r\n\r\n### Security Solution\r\n\r\nThe following refactoring changes were done in preparation for\r\nforthcoming work for supporting kibana spaces:\r\n\r\n- A new saved objects client factory service was introduced for use in\r\n`EndpointAppContextServices`\r\n- Deleted older saved objects client utilities\r\n- Simplified the list of options passed to\r\n`EndpointAppContextService#start()` method\r\n- Updated `EndpiontFleetServicesFactory` with:\r\n - simpler list of constructor arguments\r\n - changed members of object return by `asInternalUser()`\r\n- Refactored the `EndpintMetadataService` to:\r\n - take in simplified constructor arguments\r\n- Simplified most methods of the class with removal all ES Client, SO\r\nClient or Fleet services arguments from class method calling signatures.\r\nThese are not provided to the service class upon initialization and can\r\nbe accessed internally by the methods\r\n- Updates to Mocks and tests to reflect the above changes","sha":"0b1e9f475440d60260203ce2a85c8b57c4363130"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fleet Plugin
Security Solution
The following refactoring changes were done in preparation for forthcoming work for supporting kibana spaces:
EndpointAppContextServicesEndpointAppContextService#start()methodEndpiontFleetServicesFactorywith:asInternalUser()EndpintMetadataServiceto:Checklist