Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution]Analyzer in flyout Part 1 - add split mode in analyzer and enable visualization tab (#192531) #193461

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…yzer and enable visualization tab (elastic#192531)

## Summary

This PR is part 1 of moving analyzer to alerts flyout. To support
rendering the analyzer graph and details panel separately, this PR
introduced a `split` mode in analyzer:

- In split mode an additional `show panel` button is added in graph
control.

![image](https://github.com/user-attachments/assets/5af3d387-69ac-4668-95d4-aedd53e897fb)

- default mode shows the panel as part of the graph (alert table
scenario)

![image](https://github.com/user-attachments/assets/93a9f0ad-163b-45a3-9e7f-41d83e1cd85b)

## Update to analyzer state in redux

To support analyzer in alerts table and in flyout, the redux store for
alert/event table uses `scopeId` (`alerts-page` in screenshot), the
flyout analyzer uses `flyoutUrl-scopeId` (i.e.
`SecuritySolution-alerts-page`)

![image](https://github.com/user-attachments/assets/c7f50866-642a-4e5d-9d80-a303f24934cb)

### Feature flag
This feature is currently behind a feature flag
`visualizationInFlyoutEnabled`
Note: this also enables session view in visualization section

### Video demo

https://github.com/user-attachments/assets/6a95497e-1e94-42fe-a227-bbb9a7f0c303

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 2650cd0)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #15 / dashboard app - group 4 dashboard empty state adds a new data view when no data views

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5806 5809 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.4MB 20.4MB +12.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 87.0KB 87.1KB +32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

@kibanamachine kibanamachine merged commit 0977302 into elastic:8.x Sep 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants