Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix(slo): use correct uisettings (#193362) #193457

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine enabled auto-merge (squash) September 19, 2024 17:28
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Sep 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / Reporting APIs Network Policy "after all" hook for "should fail job when page violates the network policy"
  • [job] [logs] FTR Configs #2 / Reporting APIs Network Policy should fail job when page violates the network policy
  • [job] [logs] Jest Tests #16 / Severity form field selects the correct value when changed assigned to me
  • [job] [logs] Jest Tests #16 / Title it renders

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 852.9KB 853.7KB +828.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
slo 24.6KB 24.7KB +134.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kibanamachine kibanamachine merged commit 0125a03 into elastic:8.x Sep 19, 2024
28 checks passed
kdelemme added a commit that referenced this pull request Sep 25, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [fix(slo): use correct uisettings
(#193362)](#193362)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T17:23:55Z","message":"fix(slo):
use correct uisettings
(#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"number":193362,"url":"https://github.com/elastic/kibana/pull/193362","mergeCommit":{"message":"fix(slo):
use correct uisettings
(#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193362","number":193362,"mergeCommit":{"message":"fix(slo):
use correct uisettings
(#193362)","sha":"92b2c0324779711b6c95b1f90027cef210401ce9"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/193457","number":193457,"state":"MERGED","mergeCommit":{"sha":"0125a030f9055117476c4139d425cd112a43e0dc","message":"[8.x]
fix(slo): use correct uisettings (#193362) (#193457)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.x`:\n- [fix(slo): use correct
uisettings\n(#193362)](https://github.com/elastic/kibana/pull/193362)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Kevin\nDelemme\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-09-19T17:23:55Z\",\"message\":\"fix(slo):\nuse
correct
uisettings\n(#193362)\",\"sha\":\"92b2c0324779711b6c95b1f90027cef210401ce9\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"backport\",\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"backport:prev-major\",\"ci:project-deploy-observability\",\"Team:obs-ux-management\",\"v8.16.0\"],\"title\":\"fix(slo):\nuse
correct\nuisettings\",\"number\":193362,\"url\":\"https://github.com/elastic/kibana/pull/193362\",\"mergeCommit\":{\"message\":\"fix(slo):\nuse
correct
uisettings\n(#193362)\",\"sha\":\"92b2c0324779711b6c95b1f90027cef210401ce9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/193362\",\"number\":193362,\"mergeCommit\":{\"message\":\"fix(slo):\nuse
correct
uisettings\n(#193362)\",\"sha\":\"92b2c0324779711b6c95b1f90027cef210401ce9\"}},{\"branch\":\"8.x\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v8.16.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Kevin Delemme <[email protected]>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants