[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated #193428
+47
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an entity is repeated ### Summary This PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below: **Before**  **After** 
andrew-goldstein
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
andrew-goldstein
added
release_note:fix
backport:prev-minor
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
spong
approved these changes
Sep 19, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
…entity is repeated (elastic#193428) ## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated ### Summary This PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below: **Before**  **After**  (cherry picked from commit a84a045)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
…entity is repeated (elastic#193428) ## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated ### Summary This PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below: **Before**  **After**  (cherry picked from commit a84a045)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…hen an entity is repeated (#193428) (#193497) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)](#193428) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T22:37:50Z","message":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)\n\n## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated\r\n\r\n### Summary\r\n\r\nThis PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below:\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"a84a045e353c8bb2b3780065adbccc2b66b15d46","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI","v8.16.0","v8.15.2"],"title":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated","number":193428,"url":"https://github.com/elastic/kibana/pull/193428","mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)\n\n## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated\r\n\r\n### Summary\r\n\r\nThis PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below:\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"a84a045e353c8bb2b3780065adbccc2b66b15d46"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193428","number":193428,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)\n\n## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated\r\n\r\n### Summary\r\n\r\nThis PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below:\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"a84a045e353c8bb2b3780065adbccc2b66b15d46"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
…en an entity is repeated (#193428) (#193498) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)](#193428) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T22:37:50Z","message":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)\n\n## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated\r\n\r\n### Summary\r\n\r\nThis PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below:\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"a84a045e353c8bb2b3780065adbccc2b66b15d46","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI","v8.16.0","v8.15.2"],"title":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated","number":193428,"url":"https://github.com/elastic/kibana/pull/193428","mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)\n\n## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated\r\n\r\n### Summary\r\n\r\nThis PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below:\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"a84a045e353c8bb2b3780065adbccc2b66b15d46"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193428","number":193428,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated (#193428)\n\n## [Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated\r\n\r\n### Summary\r\n\r\nThis PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below:\r\n\r\n**Before**\r\n\r\n\r\n\r\n**After**\r\n\r\n","sha":"a84a045e353c8bb2b3780065adbccc2b66b15d46"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <[email protected]>
| Object.entries<string>(replacements ?? {}).reduce((acc, [key, value]) => { | ||
| const regex = new RegExp(key, 'g'); | ||
|
|
||
| return acc.replace(regex, value); |
There was a problem hiding this comment.
acc.replaceAll(key, value) would have been better here; or better still, a call to the common replacements function here and on line 47 below, so I opened a follow-up PR: #193645
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Sep 26, 2024
…nction This PR is a follow-up to <elastic#193428>, to make use of the common function for replacing anonymized values with original values
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…on (elastic#193645) ### [Security Solution] [Attack discovery] Use common replacements function This PR is a follow-up to <elastic#193428>, to make use of the common function for replacing anonymized values with original values (cherry picked from commit 30831e6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…on (elastic#193645) ### [Security Solution] [Attack discovery] Use common replacements function This PR is a follow-up to <elastic#193428>, to make use of the common function for replacing anonymized values with original values (cherry picked from commit 30831e6)
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
…function (#193645) (#194198) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [Attack discovery] Use common replacements function (#193645)](#193645) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T17:08:32Z","message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.15.3"],"title":"[Security Solution] [Attack discovery] Use common replacements function","number":193645,"url":"https://github.com/elastic/kibana/pull/193645","mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193645","number":193645,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
… function (#193645) (#194197) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] [Attack discovery] Use common replacements function (#193645)](#193645) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T17:08:32Z","message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.15.3"],"title":"[Security Solution] [Attack discovery] Use common replacements function","number":193645,"url":"https://github.com/elastic/kibana/pull/193645","mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193645","number":193645,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Use common replacements function (#193645)\n\n### [Security Solution] [Attack discovery] Use common replacements function\r\n\r\nThis PR is a follow-up to <#193428>, to make use of the common function for replacing anonymized values with original values","sha":"30831e61568d4cd58aec2493767180e05ea3ec28"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated
Summary
This PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the Before and After screenshots below:
Before
After