-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kibana upgrade notes page #193268
Add Kibana upgrade notes page #193268
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
Overall, the page looks good and as expected. Thank you. In the short term, we will have a burden on manual updates, and agree we should look for ways to improve with automation and find-ability of this content. This first version gives visibility for early planning, so I'm glad we are doing this sooner.
At some point, it makes sense to categorize this list, and this can be driven by the Obs team priorities. Let's start with improving visibility of the information for upgrade planning and publishing what is already in the release notes in an easier-to-view location. |
This seems like a great first iteration, thank you! I'm wondering how these are being manually compiled. Are we going back to the raw release note labels on PRs to find things that are labeled as breaking, using the release notes tool? Or are we combing through the existing release note docs and just copying things that are already labeled as breaking there? I'm trying to understand how we have o11y but not security coverage here... I'm guessing there's part of the release notes prep process that I'm unfamiliar with. |
@lukeelmers For this one I went manually over the Kibana asciidoc files and extracted what seemed relevant + slightly rewrote them to make the items more parallel/easier to read. The content is mirroring what we're doing on the release notes side: Kibana RNs include Obs, but Security has its own. I'm hoping that following this first iteration we can:
I also just got started with Kibana so I'm not familiar with everything yet either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if in the scope of this PR, for 9.0 devs should make (relatively short) migration guides users can follow while upgrading. We want to (deep)link to a specific migration guide from Kibana’s upgrade assistant.
I think UA can help refine this experience nicely by surfacing relevant deprecations as an upgrade checklist (i.e. ones that Kibana can see in the users stack). Can this support some kind of deep linking? Kibana core is hoping to create steps for Kibana devs to follow when deprecating, for example, an HTTP API and one of the steps would be “create a guide in docs/upgrade-notes”.
Then in Kibana we would link from upgrade assistant to that specific guide using something like: https://www.elastic.co/guide/kibana/upgrade-notes/8.last#my-api-deprecation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor suggestions, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I'd like to echo @jloleysens suggestion for these items to be something we can deeplink to from upgrade assistant.
My other suggestion would be to do some sort of grouping similar to what we do in release notes to help people understand what areas of Kibana some of these breaking changes relate to (eg platform, visualizations, observability...). This helps folks understand what they might be able to ignore and what's relevant to them. I could see this either being categories that changes are listed under, or "tags" that are added at the beginning of each change description.
Co-authored-by: Lisa Cawley <[email protected]>
@lukeelmers @jloleysens I have removed ids from specific items to not cause id conflicts with the traditional, per minor, release notes (in those ones breaking changes & deprecations have IDs). Would the need here be to link to items individually from the Upgrade Assistant, or to categories? I also wondered about categories and tried several things on my local, it makes the file much harder to read when there are many more sections with sometimes 1 item in it, so I went with chronological order, also because there aren't so many items. Maybe tags would be more helpful, or at least more explicitly call out which area of the product each item applies to in its title. Happy to collect more opinions on that. |
I would say individual items. E.g. (1) saved object HTTP API deprecations - may be a slightly longer guide/entry Linking to each of those from UA would awesome. I can imagine cases where linking to a category might be useful, but mostly linking to a specific actionable thing would be best. |
Re: categorizing, actually we may have more items than I initially included in there because I didn't add the changes from the RCs, Beta, and Alpha of v8, so it would make sense to have a 2 levels of sorting: 1/ Per area For example, this page categorizes the breaking changes. WDYT? I'll also re-add IDs for each item in that new page. So that we can link individually to them. |
I'm in the process of adding some items I initially missed, and testing various ways to organize the page. Will update when ready to share |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny tweaks, otherwise this is amazing. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught a few typos & had a few corrections, otherwise this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first step. The template and approach look good to me! Gives us both place to write guides and a way to link to them! Nice work!
docs/upgrade-notes.asciidoc
Outdated
2. Paste and edit the template in the right area section. Most recent entries should be at the top of the section. | ||
3. Make sure to edit the anchor ID [[REPO-PR]] with proper values, then add the corresponding entry to the doc link service https://github.com/elastic/kibana/blob/main/packages/kbn-doc-links/src/get_doc_links.ts: | ||
|
||
codeId: `${KIBANA_DOCS}breaking-changes-summary.html#REPO-PR` // replace `codeId` with the ID of your choice that you want to call in the Upgrade Assistant code, and replace `REPO-PR` with the corresponding values you edited in this document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% I follow what codeId
is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the ID assigned to the link in the doc link service file, that can be called in the code instead of hardcoding the link. I slightly edited the template and added a link to a small doc explaining the docs link service, hopefully this will be clearer.
Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Luke Elmers <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
Starting backport for target branches: 8.x |
## Summary This PR: - adds a page that is a compiled list of all breaking changes and deprecations introduced since the last major version. I slightly edited some bits to align the wording and add version information to each item, and took a bit of freedom (not too much!) to ignore items that shouldn't be identified as deprecations or breaking changes, or to move them to the appropriate section in this page. - adds a link to the new page from the Upgrade Kibana page. <img width="1483" alt="image" src="https://github.com/user-attachments/assets/16109072-d5c6-4eb4-8a52-ef209a07072a"> <img width="810" alt="image" src="https://github.com/user-attachments/assets/939e9212-b750-4a6f-bd8f-f8df04e46d76"> I'm wondering if we should leave this uncategorized or at least identify which items are specific to a solution. It also doesn't make much sense that we have Obs here while we don't have Security. Let's think about a consistent way to do it. Note: In this PR, the page is initially added under the Release notes section. I'll need to make sure that this does not interfere with the release notes automation. Note 2: If we move forward with this proposal, we'll need update the release notes internal docs to add the relevant information to this page with each minor release, or find a way to automate. Closes: elastic/kibana-team#1075 --------- Co-authored-by: Lisa Cawley <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Luke Elmers <[email protected]> (cherry picked from commit 94caafd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [(Docs) Add Kibana upgrade notes page (#193268)](#193268) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"florent-leborgne","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T09:51:42Z","message":"(Docs) Add Kibana upgrade notes page (#193268)\n\n## Summary\r\n\r\nThis PR:\r\n\r\n- adds a page that is a compiled list of all breaking changes and\r\ndeprecations introduced since the last major version. I slightly edited\r\nsome bits to align the wording and add version information to each item,\r\nand took a bit of freedom (not too much!) to ignore items that shouldn't\r\nbe identified as deprecations or breaking changes, or to move them to\r\nthe appropriate section in this page.\r\n- adds a link to the new page from the Upgrade Kibana page.\r\n\r\n<img width=\"1483\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/16109072-d5c6-4eb4-8a52-ef209a07072a\">\r\n\r\n<img width=\"810\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/939e9212-b750-4a6f-bd8f-f8df04e46d76\">\r\n\r\n\r\nI'm wondering if we should leave this uncategorized or at least identify\r\nwhich items are specific to a solution. It also doesn't make much sense\r\nthat we have Obs here while we don't have Security. Let's think about a\r\nconsistent way to do it.\r\n\r\nNote: In this PR, the page is initially added under the Release notes\r\nsection. I'll need to make sure that this does not interfere with the\r\nrelease notes automation.\r\n\r\nNote 2: If we move forward with this proposal, we'll need update the\r\nrelease notes internal docs to add the relevant information to this page\r\nwith each minor release, or find a way to automate.\r\n\r\nCloses: https://github.com/elastic/kibana-team/issues/1075\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley <[email protected]>\r\nCo-authored-by: Kaarina Tungseth <[email protected]>\r\nCo-authored-by: Luke Elmers <[email protected]>","sha":"94caafd57d8fcff310ca4117cbf984bbb54658cb","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","v8.16.0","backport:version"],"title":"Add Kibana upgrade notes page","number":193268,"url":"https://github.com/elastic/kibana/pull/193268","mergeCommit":{"message":"(Docs) Add Kibana upgrade notes page (#193268)\n\n## Summary\r\n\r\nThis PR:\r\n\r\n- adds a page that is a compiled list of all breaking changes and\r\ndeprecations introduced since the last major version. I slightly edited\r\nsome bits to align the wording and add version information to each item,\r\nand took a bit of freedom (not too much!) to ignore items that shouldn't\r\nbe identified as deprecations or breaking changes, or to move them to\r\nthe appropriate section in this page.\r\n- adds a link to the new page from the Upgrade Kibana page.\r\n\r\n<img width=\"1483\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/16109072-d5c6-4eb4-8a52-ef209a07072a\">\r\n\r\n<img width=\"810\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/939e9212-b750-4a6f-bd8f-f8df04e46d76\">\r\n\r\n\r\nI'm wondering if we should leave this uncategorized or at least identify\r\nwhich items are specific to a solution. It also doesn't make much sense\r\nthat we have Obs here while we don't have Security. Let's think about a\r\nconsistent way to do it.\r\n\r\nNote: In this PR, the page is initially added under the Release notes\r\nsection. I'll need to make sure that this does not interfere with the\r\nrelease notes automation.\r\n\r\nNote 2: If we move forward with this proposal, we'll need update the\r\nrelease notes internal docs to add the relevant information to this page\r\nwith each minor release, or find a way to automate.\r\n\r\nCloses: https://github.com/elastic/kibana-team/issues/1075\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley <[email protected]>\r\nCo-authored-by: Kaarina Tungseth <[email protected]>\r\nCo-authored-by: Luke Elmers <[email protected]>","sha":"94caafd57d8fcff310ca4117cbf984bbb54658cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193268","number":193268,"mergeCommit":{"message":"(Docs) Add Kibana upgrade notes page (#193268)\n\n## Summary\r\n\r\nThis PR:\r\n\r\n- adds a page that is a compiled list of all breaking changes and\r\ndeprecations introduced since the last major version. I slightly edited\r\nsome bits to align the wording and add version information to each item,\r\nand took a bit of freedom (not too much!) to ignore items that shouldn't\r\nbe identified as deprecations or breaking changes, or to move them to\r\nthe appropriate section in this page.\r\n- adds a link to the new page from the Upgrade Kibana page.\r\n\r\n<img width=\"1483\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/16109072-d5c6-4eb4-8a52-ef209a07072a\">\r\n\r\n<img width=\"810\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/939e9212-b750-4a6f-bd8f-f8df04e46d76\">\r\n\r\n\r\nI'm wondering if we should leave this uncategorized or at least identify\r\nwhich items are specific to a solution. It also doesn't make much sense\r\nthat we have Obs here while we don't have Security. Let's think about a\r\nconsistent way to do it.\r\n\r\nNote: In this PR, the page is initially added under the Release notes\r\nsection. I'll need to make sure that this does not interfere with the\r\nrelease notes automation.\r\n\r\nNote 2: If we move forward with this proposal, we'll need update the\r\nrelease notes internal docs to add the relevant information to this page\r\nwith each minor release, or find a way to automate.\r\n\r\nCloses: https://github.com/elastic/kibana-team/issues/1075\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley <[email protected]>\r\nCo-authored-by: Kaarina Tungseth <[email protected]>\r\nCo-authored-by: Luke Elmers <[email protected]>","sha":"94caafd57d8fcff310ca4117cbf984bbb54658cb"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: florent-leborgne <[email protected]>
Summary
This PR:
I'm wondering if we should leave this uncategorized or at least identify which items are specific to a solution. It also doesn't make much sense that we have Obs here while we don't have Security. Let's think about a consistent way to do it.
Note: In this PR, the page is initially added under the Release notes section. I'll need to make sure that this does not interfere with the release notes automation.
Note 2: If we move forward with this proposal, we'll need update the release notes internal docs to add the relevant information to this page with each minor release, or find a way to automate.
Closes: https://github.com/elastic/kibana-team/issues/1075