[Synthetics] Add labels field !! #193250
Merged
[Synthetics] Add labels field !! #193250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
force-pushed
the
meta-field
branch
from
779b927 to
e8d4ee6
Compare
shahzad31
changed the title
This was referenced Sep 19, 2024
shahzad31
added
backport:skip
justinkambic
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
| }), | ||
| props: ({ field, setValue, trigger }): KeyValuePairsFieldProps => ({ | ||
| readOnly, | ||
| keyLabel: i18n.translate('xpack.synthetics.monitorConfig.field.key.label', { |
There was a problem hiding this comment.
nit: how about we use Key instead of Field as label itself is considered as field?
shahzad31
added
the
backport:prev-minor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 20, 2024
## Summary Part of elastic/synthetics#729 Add labels fields !! Show them in details <img width="1520" alt="image" src="https://github.com/user-attachments/assets/36050903-d2bc-458e-9f10-a912be76a9e9"> From add/edit configs <img width="1718" alt="image" src="https://github.com/user-attachments/assets/c3ed615e-cf0f-47f5-93f4-da9464add031"> as part of es docs <img width="1728" alt="image" src="https://github.com/user-attachments/assets/35a2c4d3-a1b1-4712-a45b-19750543e82d"> (cherry picked from commit ca018a7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 20, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Add labels field !! (#193250)](#193250) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T10:50:41Z","message":"[Synthetics] Add labels field !! (#193250)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/synthetics/issues/729\r\n\r\nAdd labels fields !!\r\n\r\nShow them in details \r\n\r\n<img width=\"1520\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/36050903-d2bc-458e-9f10-a912be76a9e9\">\r\n\r\nFrom add/edit configs \r\n\r\n<img width=\"1718\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3ed615e-cf0f-47f5-93f4-da9464add031\">\r\n\r\nas part of es docs\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/35a2c4d3-a1b1-4712-a45b-19750543e82d\">","sha":"ca018a7c890c6e297d1314d9fc4cef6a7f8f741a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","release_note:feature","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] Add labels field !!","number":193250,"url":"https://github.com/elastic/kibana/pull/193250","mergeCommit":{"message":"[Synthetics] Add labels field !! (#193250)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/synthetics/issues/729\r\n\r\nAdd labels fields !!\r\n\r\nShow them in details \r\n\r\n<img width=\"1520\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/36050903-d2bc-458e-9f10-a912be76a9e9\">\r\n\r\nFrom add/edit configs \r\n\r\n<img width=\"1718\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3ed615e-cf0f-47f5-93f4-da9464add031\">\r\n\r\nas part of es docs\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/35a2c4d3-a1b1-4712-a45b-19750543e82d\">","sha":"ca018a7c890c6e297d1314d9fc4cef6a7f8f741a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193250","number":193250,"mergeCommit":{"message":"[Synthetics] Add labels field !! (#193250)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/synthetics/issues/729\r\n\r\nAdd labels fields !!\r\n\r\nShow them in details \r\n\r\n<img width=\"1520\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/36050903-d2bc-458e-9f10-a912be76a9e9\">\r\n\r\nFrom add/edit configs \r\n\r\n<img width=\"1718\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3ed615e-cf0f-47f5-93f4-da9464add031\">\r\n\r\nas part of es docs\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/35a2c4d3-a1b1-4712-a45b-19750543e82d\">","sha":"ca018a7c890c6e297d1314d9fc4cef6a7f8f741a"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of elastic/synthetics#729
Add labels fields !!
Show them in details
From add/edit configs
as part of es docs