[dashboard] Migrate Dashboard internal components to DashboardApi #193220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
nreese
changed the title
|
/ci |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
reviewed
Sep 19, 2024
Comment on lines
+55
to
+61
| const { originatingPath, originatingApp } = useMemo(() => { | ||
| const appContext = dashboardApi.getAppContext(); | ||
| return { | ||
| originatingApp: appContext?.currentAppId, | ||
| originatingPath: appContext?.getCurrentPath?.() ?? '', | ||
| }; | ||
| }, [dashboardApi]); |
src/plugins/dashboard/public/dashboard_container/embeddable/dashboard_container.tsx
Outdated
Show resolved
Hide resolved
src/plugins/dashboard/public/dashboard_container/embeddable/dashboard_container.tsx
Outdated
Show resolved
Hide resolved
…shboard_container.tsx Co-authored-by: Hannah Mudge <[email protected]>
…shboard_container.tsx Co-authored-by: Hannah Mudge <[email protected]>
Thanks for catching this. It is indeed part of component state. I have committed the suggested changes that resolve this. |
|
@elasticmachine merge upstream |
Heenawter
requested changes
Sep 20, 2024
Heenawter
approved these changes
Sep 20, 2024
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
…astic#193220) PR replaces `useDashboardContainer` with `useDashboardApi`. `useDashboardApi` returns `DashboardApi` instead of `DashboardContainer`. After this PR, all react context's in dashboard return `DashboardApi` and thus all components are now prepared for the migration from DashboardContainer to DashboardApi. --------- Co-authored-by: Hannah Mudge <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 92da176)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
…pi (#193220) (#193739) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] Migrate Dashboard internal components to DashboardApi (#193220)](#193220) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T15:21:37Z","message":"[dashboard] Migrate Dashboard internal components to DashboardApi (#193220)\n\nPR replaces `useDashboardContainer` with `useDashboardApi`.\r\n`useDashboardApi` returns `DashboardApi` instead of\r\n`DashboardContainer`.\r\n\r\nAfter this PR, all react context's in dashboard return `DashboardApi`\r\nand thus all components are now prepared for the migration from\r\nDashboardContainer to DashboardApi.\r\n\r\n---------\r\n\r\nCo-authored-by: Hannah Mudge <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"92da1767f3bab00f5b7abca16daec06e2314302b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","v8.16.0","backport:version"],"title":"[dashboard] Migrate Dashboard internal components to DashboardApi","number":193220,"url":"https://github.com/elastic/kibana/pull/193220","mergeCommit":{"message":"[dashboard] Migrate Dashboard internal components to DashboardApi (#193220)\n\nPR replaces `useDashboardContainer` with `useDashboardApi`.\r\n`useDashboardApi` returns `DashboardApi` instead of\r\n`DashboardContainer`.\r\n\r\nAfter this PR, all react context's in dashboard return `DashboardApi`\r\nand thus all components are now prepared for the migration from\r\nDashboardContainer to DashboardApi.\r\n\r\n---------\r\n\r\nCo-authored-by: Hannah Mudge <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"92da1767f3bab00f5b7abca16daec06e2314302b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193220","number":193220,"mergeCommit":{"message":"[dashboard] Migrate Dashboard internal components to DashboardApi (#193220)\n\nPR replaces `useDashboardContainer` with `useDashboardApi`.\r\n`useDashboardApi` returns `DashboardApi` instead of\r\n`DashboardContainer`.\r\n\r\nAfter this PR, all react context's in dashboard return `DashboardApi`\r\nand thus all components are now prepared for the migration from\r\nDashboardContainer to DashboardApi.\r\n\r\n---------\r\n\r\nCo-authored-by: Hannah Mudge <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"92da1767f3bab00f5b7abca16daec06e2314302b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replaces
useDashboardContainerwithuseDashboardApi.useDashboardApireturnsDashboardApiinstead ofDashboardContainer.After this PR, all react context's in dashboard return
DashboardApiand thus all components are now prepared for the migration from DashboardContainer to DashboardApi.