Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdvancedSettings] Search does not work for terms with ":" #192694

Closed
jughosta opened this issue Sep 12, 2024 · 3 comments · Fixed by #193506
Closed

[AdvancedSettings] Search does not work for terms with ":" #192694

jughosta opened this issue Sep 12, 2024 · 3 comments · Fixed by #193506
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jughosta
Copy link
Contributor

Describe the bug:
Searching for doc_table:legacy does not give results although this setting exist.

Screenshots (if relevant):

Image

@jughosta jughosta added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Sep 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@Dhiraj5789
Copy link

@jughosta Can you assign this bug to me?

@alisonelizabeth
Copy link
Contributor

Hi @Dhiraj5789 - if you would like to work on this, please go ahead and assign yourself. Thank you!

@alisonelizabeth alisonelizabeth added the good first issue low hanging fruit label Sep 19, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 25, 2024
…tic#193506)

## Summary

Fixes elastic#192694

When terms with `:`, it will be transformed to a `FieldClause`.

So, I'm try to set it back to a `TermClause` if the field is not in
`FieldDefinition`.

Example: `-defaultValue:false doc_table:high Dashboard`

![image](https://github.com/user-attachments/assets/e9519cfe-c64d-4bd4-b928-d6ffd9bfaa8b)

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Elena Stoeva <[email protected]>
(cherry picked from commit b8398c7)
kibanamachine added a commit that referenced this issue Sep 25, 2024
…ot;:&quot; (#193506) (#193965)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Advanced Settings] Fix search does not work for terms with
&quot;:&quot; (#193506)](#193506)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jusheng
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T10:36:25Z","message":"[Advanced
Settings] Fix search does not work for terms with \":\" (#193506)\n\n##
Summary\r\n\r\nFixes #192694\r\n\r\nWhen terms with `:`, it will be
transformed to a `FieldClause`.\r\n\r\nSo, I'm try to set it back to a
`TermClause` if the field is not
in\r\n`FieldDefinition`.\r\n\r\nExample: `-defaultValue:false
doc_table:high
Dashboard`\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/e9519cfe-c64d-4bd4-b928-d6ffd9bfaa8b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Elena
Stoeva
<[email protected]>","sha":"b8398c7b684d9fb4745c0d9d8c5a9c60a5eddc48","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Kibana
Management","Team:Kibana
Management","release_note:skip","💝community","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Advanced
Settings] Fix search does not work for terms with
\":\"","number":193506,"url":"https://github.com/elastic/kibana/pull/193506","mergeCommit":{"message":"[Advanced
Settings] Fix search does not work for terms with \":\" (#193506)\n\n##
Summary\r\n\r\nFixes #192694\r\n\r\nWhen terms with `:`, it will be
transformed to a `FieldClause`.\r\n\r\nSo, I'm try to set it back to a
`TermClause` if the field is not
in\r\n`FieldDefinition`.\r\n\r\nExample: `-defaultValue:false
doc_table:high
Dashboard`\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/e9519cfe-c64d-4bd4-b928-d6ffd9bfaa8b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Elena
Stoeva
<[email protected]>","sha":"b8398c7b684d9fb4745c0d9d8c5a9c60a5eddc48"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193506","number":193506,"mergeCommit":{"message":"[Advanced
Settings] Fix search does not work for terms with \":\" (#193506)\n\n##
Summary\r\n\r\nFixes #192694\r\n\r\nWhen terms with `:`, it will be
transformed to a `FieldClause`.\r\n\r\nSo, I'm try to set it back to a
`TermClause` if the field is not
in\r\n`FieldDefinition`.\r\n\r\nExample: `-defaultValue:false
doc_table:high
Dashboard`\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/e9519cfe-c64d-4bd4-b928-d6ffd9bfaa8b)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Elena
Stoeva
<[email protected]>","sha":"b8398c7b684d9fb4745c0d9d8c5a9c60a5eddc48"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jusheng Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants