-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update "Alert and action settings" docs to be generated from YAML source #191787
base: main
Are you sure you want to change the base?
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Seems fine, it covers all the needs of existing settings and we'll be in a position to adjust if needed
We don't run CI on changes only in the docs folder but if validation is left to Kibana CI we'll want to make an adjustment to https://github.com/elastic/kibana/blob/main/.buildkite/pull_requests.json#L24. If it remains static I don't see issues. If not, it could be difficult to maintain across all repositories with docs and all branches. It does need to be accessible locally by contributors in some form and this is easiest in that regard.
👍
Low, except we shut off Kibana CI on old branches. We would have to a create a docs only check, similar to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small corrections.
The following is just my opinion, and can be ignored:
- Having the example in a separate file is cumbersome. Is it possible for these to be inline and use the multi-line YAML strings?
- Rendering each setting in a collapsible section made consuming these docs hard. However, I'm quite adjusted to the old format, so take this with a grain of salt.
@kobelb, thanks very much for the excellent suggestions!
Both are fixed.
Indeed, it's a lot less cumbersome having the examples included in the YAML rather than in a separate file, so I've made that change.
I was thinking that the collapsible sections looked tidier, but on further thought I agree that the usability is much better without them. I've removed them. If you have other suggestions to improve the formatting I'm happy to add them in. Preview page is here. |
@jbudz and @lukeelmers thanks a lot for your feedback on this PR! I've addressed the suggestions so far. Are there any changes you'd like or do you think this is ready to merge? |
No concerns on my end as long as we get a ✅ from @jbudz or someone on the ops team. |
Based on feedback I've made a few changes:
|
There's an error to do with the codeowners file that I'm not sure how to fix:
That @elastic/obs-ux-onboarding-team team is also included in the codeowners file on |
💚 Build Succeeded
Metrics [docs]
History
|
This PR:
/docs/settings-gen/source/kibana-alert-action-settings.yml
) that is manually converted to Asciidoc format (kibana-alert-action-settings.asciidoc
) by means of a Perl script (docs/settings-gen/parse-settings.pl
). A preview of the new, generated page is here.docs/settings-gen/parse-settings.pl
script which does the YAML → Asciidoc conversion.All new files are added to the
/docs/source-gen
folder.This is a trial run updating only one page of settings in the docs. Later, in separate PRs, we plan to convert other pages. After all Kibana settings pages have been converted, we would ask that the Perl script be run automatically as part of the CI whenever the YAML files in
/docs/source-gen
are added or updated.Notes:
Big thanks to the amazing @lukeelmers and @KOTungseth for guiding this!
Why are we doing this? We aim to:
P.S. I haven't worked in the Kibana repo very much and would appreciate any help navigating the CI checks.
Rel: https://github.com/elastic/docs-projects/issues/239