-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboards] Created and update timestamps for Dashboard don't respect default timezone settings in advanced settings #190562
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Dashboard
Dashboard related features
good first issue
low hanging fruit
impact:needs-assessment
Product and/or Engineering needs to evaluate the impact of the change.
loe:needs-research
This issue requires some research before it can be worked on or estimated
papercut
Small "burr" in the product that we should fix.
SharedUX/fix-it-week
Bugs that have been groomed and queued up for the team's next fix it week
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
Comments
bhavyarm
added
bug
Fixes for quality problems that affect the customer experience
Feature:Dashboard
Dashboard related features
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
labels
Aug 14, 2024
Pinging @elastic/appex-sharedux (Team:SharedUX) |
kibanamachine
added
loe:needs-research
This issue requires some research before it can be worked on or estimated
impact:needs-assessment
Product and/or Engineering needs to evaluate the impact of the change.
labels
Aug 14, 2024
Dosant
added
the
SharedUX/fix-it-week
Bugs that have been groomed and queued up for the team's next fix it week
label
Aug 15, 2024
paulinashakirova
added a commit
that referenced
this issue
Oct 24, 2024
…e Advanced Settings (#196977) ## Summary This PR fixes the [#190562](#190562) where the created and updated timestamps for Dashboards do not respect the default timezone settings in advanced settings. Currently, if the user changes the timezone in the advanced settings, the timestamps for the activity monitor flyout still display timestamps from the default browser timezone. This PR ensures that the timestamps display in the desired timezone. ![Screenshot 2024-10-19 at 13 35 00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96) ![Screenshot 2024-10-19 at 13 36 02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 24, 2024
…e Advanced Settings (elastic#196977) ## Summary This PR fixes the [elastic#190562](elastic#190562) where the created and updated timestamps for Dashboards do not respect the default timezone settings in advanced settings. Currently, if the user changes the timezone in the advanced settings, the timestamps for the activity monitor flyout still display timestamps from the default browser timezone. This PR ensures that the timestamps display in the desired timezone. ![Screenshot 2024-10-19 at 13 35 00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96) ![Screenshot 2024-10-19 at 13 36 02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14) (cherry picked from commit 7fa1e18)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 24, 2024
…e Advanced Settings (elastic#196977) ## Summary This PR fixes the [elastic#190562](elastic#190562) where the created and updated timestamps for Dashboards do not respect the default timezone settings in advanced settings. Currently, if the user changes the timezone in the advanced settings, the timestamps for the activity monitor flyout still display timestamps from the default browser timezone. This PR ensures that the timestamps display in the desired timezone. ![Screenshot 2024-10-19 at 13 35 00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96) ![Screenshot 2024-10-19 at 13 36 02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14) (cherry picked from commit 7fa1e18)
kibanamachine
added a commit
that referenced
this issue
Oct 24, 2024
… in the Advanced Settings (#196977) (#197641) # Backport This will backport the following commits from `main` to `8.x`: - [fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)](#196977) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:21:12Z","message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot 2024-10-19 at 13 35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot 2024-10-19 at 13 36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-major"],"title":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings","number":196977,"url":"https://github.com/elastic/kibana/pull/196977","mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot 2024-10-19 at 13 35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot 2024-10-19 at 13 36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196977","number":196977,"mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot 2024-10-19 at 13 35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot 2024-10-19 at 13 36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Oct 24, 2024
…e in the Advanced Settings (#196977) (#197640) # Backport This will backport the following commits from `main` to `8.16`: - [fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)](#196977) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:21:12Z","message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot 2024-10-19 at 13 35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot 2024-10-19 at 13 36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-major"],"title":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings","number":196977,"url":"https://github.com/elastic/kibana/pull/196977","mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot 2024-10-19 at 13 35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot 2024-10-19 at 13 36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196977","number":196977,"mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n![Screenshot 2024-10-19 at 13 35\r\n00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)\r\n\r\n![Screenshot 2024-10-19 at 13 36\r\n02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Dashboard
Dashboard related features
good first issue
low hanging fruit
impact:needs-assessment
Product and/or Engineering needs to evaluate the impact of the change.
loe:needs-research
This issue requires some research before it can be worked on or estimated
papercut
Small "burr" in the product that we should fix.
SharedUX/fix-it-week
Bugs that have been groomed and queued up for the team's next fix it week
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
Kibana version: 8.16.0/main
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: The create and update timestamp for dashboards is not respecting the default timezone set in advanced settings.
I am in EST and but set my timezone to Europe/Istanbul. Here is what my dashboard create timestamp shows me.
The text was updated successfully, but these errors were encountered: