New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] fix flaky jest tests #190409

Merged

mbondyra merged 1 commit into elastic:main from mbondyra:lens/jest_flaky_tests

Aug 14, 2024

Contributor

mbondyra commented Aug 13, 2024 •

edited by kibanamachine

Loading

Summary

Fixes #179854 fixes #179853

Instead of debugging the original issue, I rewrote the rest of the tests from this file to testing library. The issue broke on 8.14, but just twice over the span of 6 months, so I'd not backport (unless in the future it causes more problems in 8.14)

mbondyra added Team:Visualizations release_note:skip Feature:Lens backport:prev-minor v8.16.0 labels

mbondyra requested a review from a team as a code owner

August 13, 2024 13:36

Contributor

elasticmachine commented Aug 13, 2024

Pinging @elastic/kibana-visualizations (Team:Visualizations)


          [Lens] fix flaky jest tests

262cb7f

mbondyra force-pushed the lens/jest_flaky_tests branch from e219bac to 262cb7f Compare

August 13, 2024 13:42

Collaborator

kibana-ci commented Aug 13, 2024

💚 Build Succeeded

Buildkite Build
Commit: 262cb7f

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickofthyme approved these changes

View reviewed changes

Contributor

nickofthyme left a comment

LGTM, when it doubt refactor to rtl!

x-pack/plugins/lens/public/datasources/common/field_item.test.tsx Show resolved Hide resolved

x-pack/plugins/lens/public/datasources/common/field_item.test.tsx Show resolved Hide resolved

mbondyra merged commit 833409d into elastic:main

18 checks passed

mbondyra deleted the lens/jest_flaky_tests branch

August 14, 2024 07:43

Contributor

kibanamachine commented Aug 14, 2024

💔 All backports failed

Status	Branch	Result
❌	8.15	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 190409

Questions ?

Please refer to the Backport tool documentation

kibanamachine added the backport missing label

Contributor

kibanamachine commented Aug 16, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

4 similar comments

Contributor

kibanamachine commented Sep 15, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Sep 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 1, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 2, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 3, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

9 similar comments

Contributor

kibanamachine commented Oct 4, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 7, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 8, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 9, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 10, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 11, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 14, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 16, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Oct 17, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Nov 22, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

26 similar comments

Contributor

kibanamachine commented Nov 25, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Nov 26, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Nov 27, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Nov 28, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Nov 29, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 3, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 4, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 5, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 6, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 9, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 10, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 11, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 12, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 13, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 16, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 17, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 18, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 19, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 20, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 23, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 24, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 25, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 26, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 27, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

Contributor

kibanamachine commented Dec 31, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 190409 locally

mbondyra added backport:skip and removed backport:prev-minor labels

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip Feature:Lens release_note:skip Team:Visualizations v8.16.0