Data view mgmt data view lazy #190292
Draft
Data view mgmt data view lazy #190292
+134
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
mattkime
commented
Sep 22, 2024
| @@ -69,7 +61,7 @@ export interface Props { | |||
| */ | |||
| onCancel: () => void; | |||
| defaultTypeIsRollup?: boolean; | |||
| editData?: DataView; | |||
| editData?: DataViewLazy; | |||
There was a problem hiding this comment.
This looks like an external type, not sure I want to change it.
mattkime
commented
Sep 22, 2024
| @@ -57,7 +57,7 @@ export const getEditorOpener = | |||
| } | |||
| }; | |||
|
|
|||
| const onSaveIndexPattern = (indexPattern: DataView) => { | |||
| const onSaveIndexPattern = (indexPattern: AbstractDataView) => { | |||
There was a problem hiding this comment.
try leaving this alone or change separately
mattkime
commented
Sep 22, 2024
| .getDataViewLazy(decodeURIComponent(props.match.params.id)) | ||
| .then((ip: DataViewLazy) => { | ||
| dataViewMgmtService.setDataView(ip); | ||
| // todo |
There was a problem hiding this comment.
probably want to fold in next calls into service
|
/ci |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
Unreferenced deprecated APIs
History
To update your PR or re-run it, just comment with: |
mattkime
added
the
backport:prev-major
mattkime
added a commit
that referenced
this pull request
Sep 25, 2024
## Summary Intermediate step in converting Data View Management to DataViewLazy. Moved `useCallback` functionality into central service so much of the state functionality is in one place and easier to understand and refactor. Part of #178926 Broken out from #190292 which tried to do everything in one go and became too messy. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Julia Rechkunova <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
## Summary Intermediate step in converting Data View Management to DataViewLazy. Moved `useCallback` functionality into central service so much of the state functionality is in one place and easier to understand and refactor. Part of elastic#178926 Broken out from elastic#190292 which tried to do everything in one go and became too messy. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Julia Rechkunova <[email protected]> (cherry picked from commit d772a11)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
## Summary Intermediate step in converting Data View Management to DataViewLazy. Moved `useCallback` functionality into central service so much of the state functionality is in one place and easier to understand and refactor. Part of elastic#178926 Broken out from elastic#190292 which tried to do everything in one go and became too messy. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Julia Rechkunova <[email protected]> (cherry picked from commit d772a11)
mattkime
added
backport:prev-minor
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Data View Mgmt] Implement state service (#193660)](#193660) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T14:37:17Z","message":"[Data View Mgmt] Implement state service (#193660)\n\n## Summary\r\n\r\nIntermediate step in converting Data View Management to DataViewLazy.\r\nMoved `useCallback` functionality into central service so much of the\r\nstate functionality is in one place and easier to understand and\r\nrefactor.\r\n\r\nPart of https://github.com/elastic/kibana/issues/178926\r\n\r\nBroken out from #190292 which\r\ntried to do everything in one go and became too messy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"d772a11c74af1efd05242516900f06cbeb00dd6f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data Views","Feature:Kibana Management","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-major"],"title":"[Data View Mgmt] Implement state service","number":193660,"url":"https://github.com/elastic/kibana/pull/193660","mergeCommit":{"message":"[Data View Mgmt] Implement state service (#193660)\n\n## Summary\r\n\r\nIntermediate step in converting Data View Management to DataViewLazy.\r\nMoved `useCallback` functionality into central service so much of the\r\nstate functionality is in one place and easier to understand and\r\nrefactor.\r\n\r\nPart of https://github.com/elastic/kibana/issues/178926\r\n\r\nBroken out from #190292 which\r\ntried to do everything in one go and became too messy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"d772a11c74af1efd05242516900f06cbeb00dd6f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193660","number":193660,"mergeCommit":{"message":"[Data View Mgmt] Implement state service (#193660)\n\n## Summary\r\n\r\nIntermediate step in converting Data View Management to DataViewLazy.\r\nMoved `useCallback` functionality into central service so much of the\r\nstate functionality is in one place and easier to understand and\r\nrefactor.\r\n\r\nPart of https://github.com/elastic/kibana/issues/178926\r\n\r\nBroken out from #190292 which\r\ntried to do everything in one go and became too messy.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"d772a11c74af1efd05242516900f06cbeb00dd6f"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers