Only reset unsaved changes when value has changed

[nreese]

This PR updates resetUnsavedChanges to only call setter when the resetting changes the value. The reason for this is that with the old logic, all keys would get set, triggering all sorts of subscriptions. For example, data controls fetch new data views when dataViewId changes. This action should only be triggered when dataViewId actually changes on reset and not on a reset where dataViewId is not changed

[nreese]

/ci

[nreese]

@elasticmachine merge upstream

[nreese]

/ci

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: 31e035c
• Interpreting CI Failures

Failed CI Steps

• FTR Configs #44
• FTR Configs #44

Test Failures

• [job] [logs] FTR Configs #44 / Controls Dashboard control group apply button time slider selections hitting dashboard resets selections + unapplies timeslice
• [job] [logs] FTR Configs #44 / Controls Dashboard control group apply button time slider selections hitting dashboard resets selections + unapplies timeslice

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/presentation-publishing	183	186	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
aiops	548.4KB	548.6KB	+229.0B
controls	455.7KB	456.0KB	+283.0B
dashboard	490.6KB	490.7KB	+67.0B
dataVisualizer	726.5KB	726.6KB	+121.0B
imageEmbeddable	69.0KB	69.1KB	+121.0B
links	52.4KB	52.4KB	+67.0B
ml	4.6MB	4.6MB	+283.0B
slo	853.9KB	853.9KB	+67.0B
synthetics	964.5KB	964.5KB	+67.0B
visualizations	315.6KB	315.6KB	+3.0B
total			+1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
embeddable	71.7KB	71.8KB	+121.0B
infra	52.4KB	52.4KB	+67.0B
lens	51.7KB	51.8KB	+67.0B
presentationPanel	44.0KB	44.1KB	+67.0B
visualizations	71.0KB	71.0KB	+70.0B
total			+392.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/presentation-publishing	218	221	+3

History

• 💔 Build #226411 failed 4792179

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[nreese]

Closing, replaced by #200259