-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneDiscover] Add new switch to Show row stripes
#188063
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@MichaelMarcialis The first time I saw this new option was in the One Discover mockups, and I'm just curious why we decided to add it? Was it something raised by product? Mainly thinking if this is really going to be a valuable option to offer to users. |
feels like this could be a next for @lukasolson since it's related to the density configuration of the data table. |
Yeah I'm not necessarily against doing this, mainly just looking to understand why we decided to add it and if it's a necessary option (similar to the header tokens one). I think we should be careful about which options we add to the popover to avoid overwhelming users / crowding the UI, and because each option we add means an additional property to manage on the saved search model. |
Good question, @davismcphee. This was originally proposed as part of the Discover design refresh that @andreadelrio and I collaborated on, driven by feedback from Alexandros Batsakis. I only continued to include it for the One Discover context-aware logs mockups because I was assuming that was still planned to be implemented at some point. If there was a compelling reason to exclude it though, I'd be happy to have that conversation. It's a nice-to-have in my mind, but not something I'd consider a critical requirement. As for value to users, I know some users (including myself) find it to be easier to parse table rows with that sort of styling, rather than using borders alone. |
Oh I fully agree with this, the row stripes are great for UX IMO, and we have them enabled by default in Discover currently. I just don't really think we need a toggle to turn them off since I imagine they help most users. So my ask is basically are we ok to keep row stripes enabled all the time and not offer a toggle to turn them off? |
+1 for row stripes. I'd consider to keep the default, and consider having a switch to turn them off, if there's significant user feedback for having such a switch |
Closing this as currently not planned, we can reopen any time |
Describe the feature:
It should be possible to configure the UnifiedDataTable in Discover to show / hide row stripes.
Mock:
Notes:
The text was updated successfully, but these errors were encountered: