Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataDiscovery] Remove Typescript 5.1.6 upgrade @ts-expect-error annotations #187926

Open
4 tasks
lukasolson opened this issue Jul 9, 2024 · 1 comment
Open
4 tasks

[DataDiscovery] Remove Typescript 5.1.6 upgrade @ts-expect-error annotations #187926

lukasolson opened this issue Jul 9, 2024 · 1 comment
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@lukasolson
Copy link
Member

Summary

From #186437:

This PR bumps the Typescript version used on Kibana into v5.1.6. The full set of changes can be found here and here.

In order to make assumptions over the codebase and all the type of errors I choose to mark the failures with @ts-expect-error and let each team decide how to handle it.

Our team's list of changes:
@lukasolson lukasolson added chore loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week labels Jul 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson mentioned this issue Jul 9, 2024
Merged
@kertal kertal added technical debt Improvement of the software architecture and operational architecture and removed :DataDiscovery/fix-it-week labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kertal @lukasolson @elasticmachine