-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[embeddable rebuild][controls] control group chaining #187877
Conversation
/ci |
/ci |
Pinging @elastic/kibana-presentation (Team:Presentation) |
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great, and is way simpler to follow than the old system!! The only thing I noticed is that the time slider is outputting its filters without any sort of debounce, which is causing the range slider to flash into a loading state much quicker than it used to + there is a noticeable delay as I drag:
In the old system, it looks like the time slider had a debounce of 500
on selections - not sure if it necessarily needs to be that high, but I think we should definitely debounce time slider selections :)
examples/controls_example/public/react_controls/data_controls/range_slider/has_no_results.ts
Show resolved
Hide resolved
const chainedControl$ = combineLatest([ | ||
apiPublishesFilters(chainedControlApi) | ||
? chainedControlApi.filters$ | ||
: new BehaviorSubject(undefined), | ||
apiPublishesTimeslice(chainedControlApi) | ||
? chainedControlApi.timeslice$ | ||
: new BehaviorSubject(undefined), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So clean 🔥
I will debounce timeslider in a separate PR since that is not related to this effort. |
PR implements chaining for refactored control group