Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskipped and added additional filters to test #187869

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

elena-shostak
Copy link
Contributor

@elena-shostak elena-shostak commented Jul 9, 2024

Summary

Unskipped and added additional filter for testing audit events when reading and writing saved objects.
We were filtering event by action only (http_request and saved_object_create), which probably sometimes returned audit events logged for background tasks, that lack user information.

Checklist

Fixes: #119267

@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6501

[❌] x-pack/test/security_api_integration/audit.config.ts: 30/50 tests passed.

see run history

@elena-shostak
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6503

[✅] x-pack/test/security_api_integration/audit.config.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6504

[✅] x-pack/test/security_api_integration/audit.config.ts: 100/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6505

[✅] x-pack/test/security_api_integration/audit.config.ts: 100/100 tests passed.

see run history

@elena-shostak elena-shostak added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes FTR labels Jul 10, 2024
@elena-shostak elena-shostak marked this pull request as ready for review July 10, 2024 13:39
@elena-shostak elena-shostak requested a review from a team as a code owner July 10, 2024 13:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kc13greiner kc13greiner self-requested a review July 10, 2024 13:40
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elena-shostak elena-shostak changed the title Unskipped and added login step to test Unskipped and added additional filters to test Jul 10, 2024
@elena-shostak
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / Description it renders
  • [job] [logs] FTR Configs #41 / Rule execution logic API Detection Engine - Execution logic @ess @serverless @skipInServerlessMKI Machine Learning Detection Rule - Alert Suppression with an active ML Job with interval suppression duration performs no suppression if a single alert is generated

Metrics [docs]

✅ unchanged

History

@elena-shostak elena-shostak merged commit 97e1163 into elastic:main Jul 10, 2024
22 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.0
Projects
None yet
4 participants