Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Cases] Edits case template text #187610

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 4, 2024

Summary

Relates to #181309

This PR edits UI text strings in the cases UI, in particular related to the new case template faetures.

Screenshots

Before

Case settings:
image

Case template creation:
image

Case creation:
image

After

Case settings:
image

Case template creation:

image

Case creation:

image

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature ui-copy Review of UI copy with docs team is recommended v8.15.0 v8.16.0 labels Jul 4, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review July 4, 2024 23:47
@lcawl lcawl requested a review from a team as a code owner July 4, 2024 23:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Thanks for updating it!! ❤️

@lcawl lcawl enabled auto-merge (squash) July 5, 2024 15:12
@lcawl lcawl merged commit 6a2abd6 into elastic:main Jul 8, 2024
22 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 502.3KB 502.1KB -244.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 151.8KB 151.8KB -2.0B

History

@lcawl lcawl deleted the case-templates branch July 8, 2024 23:45
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 9, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[ResponseOps][Cases] Edits case template text
(#187610)](#187610)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-08T23:42:06Z","message":"[ResponseOps][Cases]
Edits case template text
(#187610)","sha":"6a2abd68091b86b4e5b02359e346300371346f2a","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","ui-copy","v8.15.0","v8.16.0"],"title":"[ResponseOps][Cases]
Edits case template
text","number":187610,"url":"https://github.com/elastic/kibana/pull/187610","mergeCommit":{"message":"[ResponseOps][Cases]
Edits case template text
(#187610)","sha":"6a2abd68091b86b4e5b02359e346300371346f2a"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187610","number":187610,"mergeCommit":{"message":"[ResponseOps][Cases]
Edits case template text
(#187610)","sha":"6a2abd68091b86b4e5b02359e346300371346f2a"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants