Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Readme files update #187596

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Jul 4, 2024

Summary

We have been asked to stop using the second quality gate terminology in favor of kibana QA quality gate. This PR updates the readmes to reflect the new changes.

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0 labels Jul 4, 2024
@MadameSheema MadameSheema self-assigned this Jul 4, 2024
@MadameSheema MadameSheema requested review from a team as code owners July 4, 2024 18:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema enabled auto-merge (squash) July 4, 2024 18:23
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@MadameSheema MadameSheema merged commit 3065d56 into elastic:main Jul 4, 2024
16 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 4, 2024
## Summary

We have been asked to stop using the `second quality gate` terminology
in favor of `kibana QA quality gate`. This PR updates the readmes to
reflect the new changes.

(cherry picked from commit 3065d56)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. There's a comment in x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts that mentions a second quality gate. That needs to be updated for consistency.

@MadameSheema
Copy link
Member Author

Thanks for updating the docs. There's a comment in x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts that mentions a second quality gate. That needs to be updated for consistency.

Good catch!! Thanks @ashokaditya 😊

kibanamachine added a commit that referenced this pull request Jul 5, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security Solution] Readme files update
(#187596)](#187596)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-04T20:28:51Z","message":"[Security
Solution] Readme files update (#187596)\n\n## Summary\r\n\r\nWe have
been asked to stop using the `second quality gate` terminology\r\nin
favor of `kibana QA quality gate`. This PR updates the readmes
to\r\nreflect the new
changes.","sha":"3065d56a96ece4f4b73f0fd22f0b6ec38642b910","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
SecuritySolution","Team:Defend
Workflows","v8.15.0","v8.16.0"],"title":"[Security Solution] Readme
files
update","number":187596,"url":"https://github.com/elastic/kibana/pull/187596","mergeCommit":{"message":"[Security
Solution] Readme files update (#187596)\n\n## Summary\r\n\r\nWe have
been asked to stop using the `second quality gate` terminology\r\nin
favor of `kibana QA quality gate`. This PR updates the readmes
to\r\nreflect the new
changes.","sha":"3065d56a96ece4f4b73f0fd22f0b6ec38642b910"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187596","number":187596,"mergeCommit":{"message":"[Security
Solution] Readme files update (#187596)\n\n## Summary\r\n\r\nWe have
been asked to stop using the `second quality gate` terminology\r\nin
favor of `kibana QA quality gate`. This PR updates the readmes
to\r\nreflect the new
changes.","sha":"3065d56a96ece4f4b73f0fd22f0b6ec38642b910"}}]}]
BACKPORT-->

Co-authored-by: Gloria Hornero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants