Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting/Screenshotting] Backport screenshotting plugin to 7.17 #187512

Closed
tsullivan opened this issue Jul 3, 2024 · 3 comments
Closed

[Reporting/Screenshotting] Backport screenshotting plugin to 7.17 #187512

tsullivan opened this issue Jul 3, 2024 · 3 comments
Labels
Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

This issue is to backport #120110 to the 7.17 branch.

Why we want to do this: in keeping Puppeteer and Chromium up-to-date to support Kibana Reporting, we routinely spend a lot of time re-doing the Puppeteer changes in the 7.17 branch. Due to #120110 not having been backported, the changes from main can't easily be carried back.

Backporting #120110 to the 7.17 branch will allow us to move more quickly on keeping Chromium and Puppeteer up-to-date.

@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Jul 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan
Copy link
Member Author

tsullivan commented Jul 15, 2024

I explored the feasibility of re-implementing the same change to main that split out the screenshotting functionality from Reporting plugin. Doing a change like this in 7.17 is prohibitively complex, as the screenshotting plugin has binding with Kibana build tasks. It is also complex for other reasons, as it has a "public" layer of code, it includes translations, test helpers, and mocks.

I investigated the extent we can ease the headache of manual backport by looking at the types of changes we currently manually backport when Chromium is updated. Example.

  1. The paths.ts and args.test.ts files have a different location in main and 7.17.
  2. We should move paths.ts, args.test.ts and args.ts files to a new package.
  3. Implement the package in main and 7.17 so that the files have the same location in both branches.

While this will ease the headache of manual backports, it won't solve it. For every backport there also is a change to the yarn.lock file and manual backports will be required there.

@tsullivan tsullivan added the Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export label Aug 1, 2024
@tsullivan
Copy link
Member Author

Replaced with #188390 and #190950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

2 participants