-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Fix small issue with unknown indicators #187326
Conversation
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @sabarasaba! Tested locally and the UI works now.
I left a comment regarding future-proofing against similar scenarios with no details
field provided. Let me know what you think.
x-pack/plugins/upgrade_assistant/server/lib/es_deprecations_status.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
x-pack/plugins/upgrade_assistant/server/lib/es_deprecations_status.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
cc @sabarasaba |
Closes #186247
Summary
The ES api can sometimes return an indicator that has status unknown and that only has a symptom (no details). For example:
disk: { status: 'unknown', symptom: 'No disk usage data.' }
. This PR makes sure that the UI doesnt break in this specific scenario and creates a warning indicator anyway with the minimal information that was provided by the API.How to test
es_deprecations
page and aNo disk usage
deprecation is shown.