Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Fix small issue with unknown indicators #187326

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jul 2, 2024

Closes #186247

Summary

The ES api can sometimes return an indicator that has status unknown and that only has a symptom (no details). For example: disk: { status: 'unknown', symptom: 'No disk usage data.' }. This PR makes sure that the UI doesnt break in this specific scenario and creates a warning indicator anyway with the minimal information that was provided by the API.

How to test
  • Start up kibana and es
  • Run the following command in console:
 PUT _cluster/settings
 {
     "persistent": {
         "health.node.enabled": false
     }
 }
  • Navigate to Stack management -> Upgrade assistant
  • Verify that:
    • ES deprecations box shows one warning
    • Clicking on it goes to the es_deprecations page and a No disk usage deprecation is shown.

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant backport:skip This commit does not require backporting v8.15.0 labels Jul 2, 2024
@sabarasaba sabarasaba self-assigned this Jul 2, 2024
@sabarasaba
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 157.0KB 157.0KB +3.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba marked this pull request as ready for review July 2, 2024 10:20
@sabarasaba sabarasaba requested a review from a team as a code owner July 2, 2024 10:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @sabarasaba! Tested locally and the UI works now.
I left a comment regarding future-proofing against similar scenarios with no details field provided. Let me know what you think.

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 157.0KB 157.0KB +3.0B

cc @sabarasaba

@sabarasaba sabarasaba merged commit 077d1e0 into elastic:main Jul 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Assistant showing 500 error with unknown disk health
4 participants