Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Reduce BrowserField to field spec #187263

Merged
merged 7 commits into from
Jul 4, 2024
Merged

[Security Solution] Reduce BrowserField to field spec #187263

merged 7 commits into from
Jul 4, 2024

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Jul 1, 2024 •
edited
Loading

Summary

As both types are the same now, I am making them an alias temporarily.

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team labels Jul 1, 2024
@lgestc lgestc marked this pull request as ready for review July 1, 2024 15:01
@lgestc lgestc requested review from a team as code owners July 1, 2024 15:01
@lgestc lgestc requested a review from dhurley14 July 1, 2024 15:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

kqualters-elastic
kqualters-elastic approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@elastic elastic deleted a comment from elasticmachine Jul 4, 2024
@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

History

  • 💔 Build #219595 failed fa290739bbae7a49414bfb1a9604f529860f2384

@lgestc lgestc force-pushed the reduce_browser_field_to_field_spec branch 2 times, most recently from f5ca49f to ddb85e0 Compare July 4, 2024 14:12
@lgestc lgestc enabled auto-merge (squash) July 4, 2024 14:28
@lgestc lgestc merged commit d823d5d into elastic:main Jul 4, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@dhurley14 dhurley14 dhurley14 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgestc @elasticmachine @dhurley14 @kqualters-elastic @kibanamachine