[SecuritySolution] Revert defend-workflows integration tests #187257
Conversation
|
buildkite test this |
angorayc
added
Team:Defend Workflows
|
buildkite test this |
…a into revert-ingegrations-tests
|
buildkite test this |
|
buildkite test this |
|
buildkite test this |
|
buildkite test this |
|
buildkite test this |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
buildkite test this |
|
buildkite test this |
|
/ci |
| @@ -0,0 +1,145 @@ | |||
| /* | |||
There was a problem hiding this comment.
Move the shared utils to x-pack/test/common/services/security_solution/ to avoid type check confusion:
|
/ci |
|
buildkite test this |
|
buildkite test this |
|
buildkite test this |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
|
|
||
| export default function (providerContext: FtrProviderContext) { | ||
| const { loadTestFile, getService, getPageObjects } = providerContext; | ||
|
|
||
| // Flaky: https://github.com/elastic/kibana/issues/186089 | ||
| describe('@skipInServerless endpoint', function () { | ||
| describe('endpoint', function () { |
There was a problem hiding this comment.
@skipInServerless should stay
| // It's flaky only in Serverless | ||
| // Failing: See https://github.com/elastic/kibana/issues/187314 | ||
| // Failing: See https://github.com/elastic/kibana/issues/187383 | ||
| describe.skip('@ess @serverless For each artifact list under management', function () { |
There was a problem hiding this comment.
I believe linked failures are from ESS not Serverless? 🤔
There was a problem hiding this comment.
Ok, I'll remove the It's flaky only in Serverless comment. This test is currently unskipped , and only running on ESS. Should I add @serverless to this test?
| // Failing: See https://github.com/elastic/kibana/issues/187314 | ||
| // Failing: See https://github.com/elastic/kibana/issues/187383 | ||
| describe.skip('@ess @serverless For each artifact list under management', function () { | ||
| describe('For each artifact list under management', function () { | ||
| targetTags(this, ['@ess', '@skipInServerless']); |
There was a problem hiding this comment.
Question: is targetTags something we are switching to from inline tags?
There was a problem hiding this comment.
security_solution_api_integration supports inline tags; while x-pack/test supports only targetTags.
Given that we are moving tests back to x-pack/test, we should revert the way we apply tags as well.
| @@ -23,6 +25,8 @@ export const services = { | |||
| endpointPolicyTestResources: EndpointPolicyTestResourcesProvider, | |||
| endpointArtifactTestResources: EndpointArtifactsTestResources, | |||
| rolesUsersProvider: RolesUsersProvider, | |||
| endpointDataStreamHelpers: SecuritySolutionEndpointDataStreamHelpers, | |||
There was a problem hiding this comment.
Question: Is there any upside to adding those as services instead of regular imports in tests?
There was a problem hiding this comment.
From my perspective, it's mainly for maintenance. I tried to imported it straight away in the code, e.g.: in security_solution_endpoint folder,
import {something} from '{somewhere}/security_solution_api_integration/test_suites/security_solution_endpoint_api_int/registry.ts'
It gave me a coupe of type check error: #187257 (comment)
Therefore, I moved them to the services folder and follow the getService pattern to apply them in the code.
…a into revert-ingegrations-tests
💚 Build Succeeded
Metrics [docs]
History
|
kibanamachine
added
v8.16.0
backport:skip
Summary
#183611
I moved x-pack/test/security_solution_endpoint to x-pack/test/security_solution_api_integration in #183611 as I thought all the tests regarding Security Solution should live there.
However security_solution_endpoint are not api tests , they are UI tests. After discussions, we decided to move security_solution_endpoint back to
x-pack/test/The two files below are shared between
x-pack/test/security_solution_api_integration/test_suites/security_solution_endpoint_api_intandx-pack/test/security_solution_endpoint, moved them toservicesin this PR to avoid type check confusion.