[Discover] View mode changes should trigger Unsaved changes badge in ES|QL #187244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:skip
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @jughosta |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
reviewed
Jul 5, 2024
Comment on lines
+410
to
+414
| if (fieldName === 'viewMode') { | ||
| // By default, viewMode: undefined is equivalent to documents view | ||
| // So they should be treated as same | ||
| return savedSearch.viewMode ?? VIEW_MODE.DOCUMENT_LEVEL; | ||
| } |
There was a problem hiding this comment.
Tested and this PR fixes the issue 👍. one ask, this is the actual fix of the problem, right? Could you add a unit test for it in discover_saved_search_container.test.ts? it would be great to increase coverage in this case 🙏
There was a problem hiding this comment.
@kertal The actual fix is in src/plugins/discover/public/application/main/state_management/utils/build_state_subscribe.ts. Here it's only a stylistic choice.
There was a problem hiding this comment.
Ah, got it, thx a lot for adding more tests anyway 👍
kertal
approved these changes
Jul 5, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
cc @jughosta |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 5, 2024
…ES|QL (elastic#187244) - Closes elastic#184624 ## Summary This PR updates the logic to show Unsaved changes badge when view mode changes in ES|QL mode. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Matthias Wilhelm <[email protected]> (cherry picked from commit 25d7346)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2024
…dge in ES|QL (#187244) (#187687) # Backport This will backport the following commits from `main` to `8.15`: - [[Discover] View mode changes should trigger Unsaved changes badge in ES|QL (#187244)](#187244) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-05T14:46:00Z","message":"[Discover] View mode changes should trigger Unsaved changes badge in ES|QL (#187244)\n\n- Closes https://github.com/elastic/kibana/issues/184624\r\n\r\n## Summary\r\n\r\nThis PR updates the logic to show Unsaved changes badge when view mode\r\nchanges in ES|QL mode.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <[email protected]>","sha":"25d73466c3e1afff0c17b7f8800f92449e9480a8","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.16.0"],"title":"[Discover] View mode changes should trigger Unsaved changes badge in ES|QL","number":187244,"url":"https://github.com/elastic/kibana/pull/187244","mergeCommit":{"message":"[Discover] View mode changes should trigger Unsaved changes badge in ES|QL (#187244)\n\n- Closes https://github.com/elastic/kibana/issues/184624\r\n\r\n## Summary\r\n\r\nThis PR updates the logic to show Unsaved changes badge when view mode\r\nchanges in ES|QL mode.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <[email protected]>","sha":"25d73466c3e1afff0c17b7f8800f92449e9480a8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187244","number":187244,"mergeCommit":{"message":"[Discover] View mode changes should trigger Unsaved changes badge in ES|QL (#187244)\n\n- Closes https://github.com/elastic/kibana/issues/184624\r\n\r\n## Summary\r\n\r\nThis PR updates the logic to show Unsaved changes badge when view mode\r\nchanges in ES|QL mode.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <[email protected]>","sha":"25d73466c3e1afff0c17b7f8800f92449e9480a8"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
kibanamachine
added
v8.15.0
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the logic to show Unsaved changes badge when view mode changes in ES|QL mode.
Checklist