Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability AI Assistant] "Stop generating" shows an error toast #186794

Closed
dgieselaar opened this issue Jun 24, 2024 · 0 comments · Fixed by #195331
Closed

[Observability AI Assistant] "Stop generating" shows an error toast #186794

dgieselaar opened this issue Jun 24, 2024 · 0 comments · Fixed by #195331
Assignees
@viduni94
Labels
bug Fixes for quality problems that affect the customer experience Team:Obs AI Assistant Observability AI Assistant

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Jun 24, 2024 •
edited
Loading

We erroneously show a toast to the user if they click on "stop generating". This is not helpful to the user, they know they've aborted the current action.

Image
@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:Obs AI Assistant Observability AI Assistant labels Jun 24, 2024
@dgieselaar dgieselaar changed the title [Observability AI Assistant] Aborting a request shows a toast [Observability AI Assistant] "Stop generating" shows an error toast Jun 24, 2024
@walterra walterra mentioned this issue Jun 24, 2024
Merged
2 tasks
@grabowskit grabowskit mentioned this issue Jul 9, 2024
Closed
@viduni94 viduni94 mentioned this issue Oct 7, 2024
Merged
viduni94 added a commit to viduni94/kibana that referenced this issue Oct 7, 2024
@viduni94
[Obs AI Assistant] Avoid showing error toast when action is aborted b…
3eb2372 
…y user (elastic#186794)
viduni94 added a commit that referenced this issue Oct 8, 2024
@viduni94
[Obs AI Assistant] Avoid showing error toast when action is aborted b… (
43a3d4a 
#195331)

Closes #186794

## Summary

### Problem
When the user clicks on "Stop generating" while the AI Assistant is
generating an answer, an error toast is shown with the error message
"Aborted". This is unnecessary as the user knows they aborted their
action.

### Solution
Do not show an error toast if the action is aborted by the user.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 8, 2024
@viduni94
[Obs AI Assistant] Avoid showing error toast when action is aborted b… (
43a849a 
elastic#195331)

Closes elastic#186794

## Summary

### Problem
When the user clicks on "Stop generating" while the AI Assistant is
generating an answer, an error toast is shown with the error message
"Aborted". This is unnecessary as the user knows they aborted their
action.

### Solution
Do not show an error toast if the action is aborted by the user.

(cherry picked from commit 43a3d4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viduni94 viduni94

Labels
bug Fixes for quality problems that affect the customer experience Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Obs AI Assistant] Avoid showing error toast when action is aborted b… viduni94/kibana
2 participants
@dgieselaar @viduni94