Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console][Monaco] Requests can be sent without verb #186768

Closed
sakurai-youhei opened this issue Jun 23, 2024 · 3 comments
Closed

[Console][Monaco] Requests can be sent without verb #186768

sakurai-youhei opened this issue Jun 23, 2024 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sakurai-youhei
Copy link
Member

Kibana version: 74a202a

Elasticsearch version: 8.15.0-SNAPSHOT

Server OS version: Linux wsl 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Browser version: Chrome Version 126.0.6478.63 (Official Build) (64-bit)

Browser OS version: Windows 11 10.0.22621 N/A Build 22621

Original install method (e.g. download page, yum, from source, etc.): Build from source

Describe the bug: The console allows POST-ing to /api/console/proxy?path=&method=, which is probably unintended behavior and should be gated prior to the API call; these kinds of API calls are blocked on 8.14.1.

Steps to reproduce:

  1. Go to Kibana > Dev Tools > Console.
  2. Type in 1 at a blank line.
  3. Press Ctrl+i to make an API call.

Expected behavior: The API call is blocked like on 8.14.1.
image

Screenshots (if relevant):
image

Errors in browser console (if relevant):

POST http://localhost:5601/gor/api/console/proxy?path=&method= 400 (Bad Request)
@sakurai-youhei sakurai-youhei added bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature labels Jun 23, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 23, 2024
@jughosta jughosta added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jun 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 23, 2024
@yuliacech
Copy link
Contributor

The code in MonacoEditorActionsProvider should check if the request is valid before doing any request actions like sending the request, opening documentation etc

@sabarasaba sabarasaba self-assigned this Jul 30, 2024
@sabarasaba
Copy link
Member

Fixed with #189515 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

5 participants