Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CloudSecurity] Fixing Detection Rule FTR tests #186667

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Jun 21, 2024

Summary

This fixes #168991, #172312 and #182444

This PR fixes FTR tests for the Cloud Security Posture and Detection Rules integration by adding an await pageObjects.header.waitUntilLoadingHasFinished(); after the navigation actions before checking for the assertions on the navigated page.

@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.15.0 labels Jun 21, 2024
@opauloh opauloh requested a review from a team as a code owner June 21, 2024 20:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6368

[❌] x-pack/test/cloud_security_posture_functional/config.ts: 70/100 tests passed.

see run history

Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially approved, but then saw that flaky test runner reported that 30 out of 100 runs failed. I guess that means that we still can't unskip without further investigation.
Though it looks like the issue is with a different set of tests, should we skip the flaky set and re-run the flaky test runner to make sure this fix works?

@maxcold maxcold self-requested a review June 24, 2024 11:39
@opauloh
Copy link
Contributor Author

opauloh commented Jun 24, 2024

initially approved, but then saw that flaky test runner reported that 30 out of 100 runs failed. I guess that means that we still can't unskip without further investigation. Though it looks like the issue is with a different set of tests, should we skip the flaky set and re-run the flaky test runner to make sure this fix works?

Yes, all the errors flaky errors were actually due to the integration name which I am trying to fix it here.

image

I will try re-running the flaky checking with the other test skipped for us to check!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6387

[❌] x-pack/test/cloud_security_posture_functional/config.ts: 75/100 tests passed.

see run history

@opauloh
Copy link
Contributor Author

opauloh commented Jun 25, 2024

It seems to be fixed now, got only random errors on the flaky runner

@opauloh opauloh merged commit c73a3ab into elastic:main Jun 25, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment