-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CloudSecurity] Fixing Detection Rule FTR tests #186667
[CloudSecurity] Fixing Detection Rule FTR tests #186667
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6368[❌] x-pack/test/cloud_security_posture_functional/config.ts: 70/100 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initially approved, but then saw that flaky test runner reported that 30 out of 100 runs failed. I guess that means that we still can't unskip without further investigation.
Though it looks like the issue is with a different set of tests, should we skip the flaky set and re-run the flaky test runner to make sure this fix works?
Yes, all the errors flaky errors were actually due to the integration name which I am trying to fix it here. I will try re-running the flaky checking with the other test skipped for us to check! |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6387[❌] x-pack/test/cloud_security_posture_functional/config.ts: 75/100 tests passed. |
It seems to be fixed now, got only random errors on the flaky runner |
Summary
This fixes #168991, #172312 and #182444
This PR fixes FTR tests for the Cloud Security Posture and Detection Rules integration by adding an
await pageObjects.header.waitUntilLoadingHasFinished();
after the navigation actions before checking for the assertions on the navigated page.