[Search] Fix search index rerendering unnecessarily #186412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
HistoryTo update your PR or re-run it, just comment with: |
...earch/public/applications/enterprise_search_content/components/search_index/search_index.tsx
Show resolved
Hide resolved
TattdCodeMonkey
approved these changes
Jun 18, 2024
sphilipse
added
v8.14.2
and removed
backport:skip
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
sphilipse
added
auto-backport
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
that referenced
this pull request
Jul 4, 2024
## Summary This fixes the search index rerendering on every change, even if nothing actually changed. (cherry picked from commit 141044e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
sphilipse
added a commit
to sphilipse/kibana
that referenced
this pull request
Jul 4, 2024
## Summary This fixes the search index rerendering on every change, even if nothing actually changed. (cherry picked from commit 141044e)
kibanamachine
added a commit
that referenced
this pull request
Jul 4, 2024
…187558) # Backport This will backport the following commits from `main` to `8.14`: - [[Search] Fix search index rerendering unnecessarily (#186412)](#186412) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-18T21:35:24Z","message":"[Search] Fix search index rerendering unnecessarily (#186412)\n\n## Summary\r\n\r\nThis fixes the search index rerendering on every change, even if nothing\r\nactually changed.","sha":"141044e51ec77ea7c5e68c9311a381aecb515497","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","Team:Search","auto-backport","v8.15.0","v8.14.2"],"number":186412,"url":"https://github.com/elastic/kibana/pull/186412","mergeCommit":{"message":"[Search] Fix search index rerendering unnecessarily (#186412)\n\n## Summary\r\n\r\nThis fixes the search index rerendering on every change, even if nothing\r\nactually changed.","sha":"141044e51ec77ea7c5e68c9311a381aecb515497"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/186412","number":186412,"mergeCommit":{"message":"[Search] Fix search index rerendering unnecessarily (#186412)\n\n## Summary\r\n\r\nThis fixes the search index rerendering on every change, even if nothing\r\nactually changed.","sha":"141044e51ec77ea7c5e68c9311a381aecb515497"}},{"branch":"8.14","label":"v8.14.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
kibanamachine
removed
the
backport missing
|
This PR didn't make it on time to be included in the latest BC for v8.14.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the search index rerendering on every change, even if nothing actually changed.