[data.search] Remove total hits shimming (legacyHitsTotal)
#186144
Assignees
Labels
chore
Feature:Search
Querying infrastructure in Kibana
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
performance
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
technical debt
Improvement of the software architecture and operational architecture
Comments
lukasolson
added
Feature:Search
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
lukasolson
added
loe:small
kertal
added
technical debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary:
A long time ago in an Elastic Stack far, far away, the format that Elasticsearch returned the total number of hits in a search response changed. Prior to the change, the number of hits was always returned, and after the change, you could opt in/out to receiving the exact number of hits vs. a range.
During this period of time, we updated the
data.searchservices to have a property,legacyHitsTotal, to preserve the existing format for the hits count. As that change was a very long time ago, and as we are trying to remove server-side processing of responses to get to a point where we can stream the response directly to the client, we need to remove this special handling. We also need to verify that consumers that are displaying the count don't have any regressions in displaying the counts (or ranges) correctly.Related: #55974, #91742
The text was updated successfully, but these errors were encountered: