Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Report kibana:plugin_render_time metric event. #186129

Open
Tracked by #182073
kertal opened this issue Jun 12, 2024 · 1 comment · May be fixed by #194754
Open
Tracked by #182073

[Discover] Report kibana:plugin_render_time metric event. #186129

kertal opened this issue Jun 12, 2024 · 1 comment · May be fixed by #194754
Assignees
Labels
blocked Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. telemetry Issues related to the addition of telemetry to a feature

Comments

@kertal
Copy link
Member

kertal commented Jun 12, 2024

The metric kibana:plugin_render_time measures the time from the start of navigation to the point at which the most meaningful component appears on the screen.

https://docs.elastic.dev/kibana-dev-docs/tutorial/performance/adding_custom_performance_metrics#how-it-works

What's the most meaningful component on the screen? One could argue, it's when data is rendered in the Data Table

*/
export const DiscoverGrid: React.FC<UnifiedDataTableProps> = (props) => {
return (
<UnifiedDataTable
showColumnTokens
enableComparisonMode
renderCustomToolbar={renderCustomToolbar}
{...props}
/>
);
};

However, this would not cover the following:

  • No data state
  • Error data state
  • Legay table
  • No automatic start of data fetching
  • View surrounding documents view
  • View single documents state

So it would need some research if the most meaningful component could be the data table, or if there are alternatives.

@kertal kertal added the Project:OneDiscover Enrich Discover with contextual awareness label Jun 12, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 12, 2024
@kertal kertal added Feature:Discover Discover Application telemetry Issues related to the addition of telemetry to a feature Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 12, 2024
@kertal kertal added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jun 12, 2024
@kertal kertal added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Sep 23, 2024
@kertal kertal added the blocked label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. telemetry Issues related to the addition of telemetry to a feature
Projects
None yet
4 participants