Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Monaco migration] "Apply indentations" also collapses the request #185891

Closed
yuliacech opened this issue Jun 10, 2024 · 3 comments
Closed
Assignees
Labels
enhancement New value added to drive a business result Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

The ace editor has a functionality that when the button "apply indentations" is clicked repeatedly, the request body is toggle between being expanded and collapsed (see screen recording below). This is not yet implemented for monaco

Screen.Recording.2024-06-10.at.18.34.39.mov
@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jun 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva
Copy link
Contributor

I'm not sure if this behavior in the Ace editor was intentional as I don't remember seeing any logic for expanding/collapsing when clicking repeatedly. 🤔

@yuliacech yuliacech self-assigned this Aug 19, 2024
@alisonelizabeth alisonelizabeth added the enhancement New value added to drive a business result label Sep 19, 2024
@ElenaStoeva
Copy link
Contributor

ElenaStoeva commented Oct 17, 2024

I think this behavior might have been a result of a bug in the Ace editor as it doesn't make sense to collapse the request when applying auto-indention since this is not correct formatting. If that was intentional, I would expect to have a separate button for "Expand/collapse request". Also, afaik no one has requested this functionality, so I'll close as not planned.

@ElenaStoeva ElenaStoeva closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

4 participants