Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Select line chart by default if the x-axis contains a timestamp #184102

Closed
teresaalvarezsoler opened this issue May 23, 2024 · 2 comments · Fixed by #190786
Closed

[Lens] Select line chart by default if the x-axis contains a timestamp #184102

teresaalvarezsoler opened this issue May 23, 2024 · 2 comments · Fixed by #190786
Assignees
@mbondyra
Labels
blocked Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@teresaalvarezsoler
Copy link

Problem
We always show a bar chart for time series, however, most of the time, the best option to visualize time series data are line charts.

Solution
Show a line chart instead of a bar chart in the following circumstances if the user has not explicitly selected a chart:

  • Drags and drop/selects a timestamp field in the x-axis
  • Drags and drop/selects another field and the timestamp is added by default to the x-axis
@botelastic botelastic bot added the needs-team Issues missing a team label label May 23, 2024
@teresaalvarezsoler teresaalvarezsoler added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed needs-team Issues missing a team label labels May 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@teresaalvarezsoler teresaalvarezsoler added Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels May 23, 2024
@teresaalvarezsoler teresaalvarezsoler added loe:small Small Level of Effort and removed triage_needed labels Jul 11, 2024
@mbondyra mbondyra self-assigned this Aug 20, 2024
@mbondyra mbondyra mentioned this issue Aug 20, 2024
Merged
@mbondyra
Copy link
Contributor

Will not merge till this one is solved: #186076

@MichaelMarcialis MichaelMarcialis mentioned this issue Aug 27, 2024
Open
mbondyra added a commit that referenced this issue Oct 21, 2024
@mbondyra
[Lens] Select line chart by default if the x-axis contains a timestamp (
2d744ff 
#190786)

## Summary

Partially resolves #184102

When dropping a field to a workspace that will create the date histogram
visualization, it converts to line. It doesn't do it when dropping to a
dimension as it's more complicated thing. The reason for it is that we
would have to:
- decide if we also want to switch to line when choosing a field from
the config panel
- allow for an extra behavior (switching visualization types) for the
onDrop callback except for only modifying dimensions.


## Release notes

When dropping a field into the Lens workspace, the default time-series
visualization is a line chart instead of a histogram.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 21, 2024
@mbondyra
[Lens] Select line chart by default if the x-axis contains a timestamp (
7999d7e 
elastic#190786)

## Summary

Partially resolves elastic#184102

When dropping a field to a workspace that will create the date histogram
visualization, it converts to line. It doesn't do it when dropping to a
dimension as it's more complicated thing. The reason for it is that we
would have to:
- decide if we also want to switch to line when choosing a field from
the config panel
- allow for an extra behavior (switching visualization types) for the
onDrop callback except for only modifying dimensions.

## Release notes

When dropping a field into the Lens workspace, the default time-series
visualization is a line chart instead of a histogram.

(cherry picked from commit 2d744ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
blocked Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Select line chart by default if the x-axis contains a timestamp mbondyra/kibana
3 participants
@mbondyra @elasticmachine @teresaalvarezsoler