Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Large number of related integrations can impact performance on rule creation/edit form #183607

Open
Tracked by #179907
vitaliidm opened this issue May 16, 2024 · 6 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Creation Security Solution Detection Rule Creation workflow Feature:Rule Edit Security Solution Detection Rule Editing workflow impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. performance Team:Detection Engine Security Solution Detection Engine Area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@vitaliidm
Copy link
Contributor

vitaliidm commented May 16, 2024

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168

Summary

Describe the bug:
Large number of related integrations can cause significant performance impact on rule creation/edit form.

Steps to reproduce:

  1. Go to rule edit/create form
  2. Add multiple related integrations
  3. Type query in query bar. There is a noticeable delay in response on browser page
  4. Observe in profiler, related integrations could take up to up to 10ms to re-render on each symbol typed.
    Potentially, even longer, if more added.

Current behavior:
Each added item to related integrations contribute to the total time of form re-rendering.
Component re-renders on any change in form. So, even typing query, that does not effect state of related integrations, causes this component to re-render.
Each added item, adds approx. 1ms in rendering time. For 8 items it takes 8ms, out of 30ms of total form re-render time.

Expected behavior:
Component should not re-render when thee are no changes in form that affect it.
Similar issue was discovered for required fields and handled in relevant PR

Screenshots (if relevant):

Screenshot 2024-05-16 at 10 19 30
@vitaliidm vitaliidm added bug Fixes for quality problems that affect the customer experience performance triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels May 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@yctercero
Copy link
Contributor

Hey @banderror ! Would it be ok to assign this one to Rules Management to look into?

@banderror
Copy link
Contributor

@yctercero Of course, it's the feature we added so we'll address the performance concerns as well. Thank you @vitaliidm!

@banderror banderror changed the title [Security Solution][Detection Engine] large number of related integrations can cause significant performance impact on rule creation/edit form [Security Solution] Large number of related integrations can impact performance on rule creation/edit form May 21, 2024
@banderror banderror added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team Feature:Rule Creation Security Solution Detection Rule Creation workflow Feature:Rule Edit Security Solution Detection Rule Editing workflow 8.15 candidate and removed triage_needed labels May 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Creation Security Solution Detection Rule Creation workflow Feature:Rule Edit Security Solution Detection Rule Editing workflow impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. performance Team:Detection Engine Security Solution Detection Engine Area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

6 participants