Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Using Chrome on CI for Cypress #183515

Merged
merged 21 commits into from
May 16, 2024
Merged

[Security Solution] Using Chrome on CI for Cypress #183515

merged 21 commits into from
May 16, 2024
+105 −20

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented May 15, 2024 •
edited by kibanamachine
Loading

Summary

Fixes: #183098

Lately we have experienced some issues with our Cypress tests, where we are seeing that tests are passing but the output is marked as a failure.

@patrykkopycinski has done a great job trying to fix the issue but lately we have seen that is still reproducible.

The issue seems to be related directly with electron, so in this PR we reenabling chrome on CI to try to fix it.

In order to do so, some adjustments has been introduced to woraround the chrome out of memory crashes that we faced before and was the main reason to move to electron.

@MadameSheema
Copy link
Member Author

/ci

@MadameSheema MadameSheema self-assigned this May 15, 2024
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0 v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels May 15, 2024
@MadameSheema MadameSheema marked this pull request as ready for review May 15, 2024 14:56
@MadameSheema MadameSheema requested a review from ashokaditya May 15, 2024 14:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

12 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@MadameSheema MadameSheema deleted the cypress/chrome branch June 28, 2024 10:56
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@MadameSheema MadameSheema removed v8.14.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 5, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 26, 2024
@MadameSheema MadameSheema removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 27, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@MadameSheema MadameSheema removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 2, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 3, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@MadameSheema MadameSheema added the backport:skip This commit does not require backporting label Oct 3, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkirchan dkirchan dkirchan approved these changes

@szwarckonrad szwarckonrad szwarckonrad approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@oatkiller oatkiller Awaiting requested review from oatkiller

@maximpn maximpn Awaiting requested review from maximpn

@banderror banderror Awaiting requested review from banderror

@ashokaditya ashokaditya Awaiting requested review from ashokaditya ashokaditya was automatically assigned from elastic/security-defend-workflows

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting ci:all-cypress-suites release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cypress] Incorrect test summary
8 participants
@MadameSheema @elasticmachine @patrykkopycinski @kibana-ci @kibanamachine @delanni @szwarckonrad @dkirchan