Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV reporting needs to handle empty reports better. #18320

Closed
elasticmachine opened this issue Nov 8, 2017 · 9 comments
Closed

CSV reporting needs to handle empty reports better. #18320

elasticmachine opened this issue Nov 8, 2017 · 9 comments
Labels
enhancement New value added to drive a business result Feature:Reporting:CSV Reporting issues pertaining to CSV file export good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label

Comments

@elasticmachine
Copy link
Contributor

Original comment by @bhavyarm:

Kibana version: 6.0.0 BC1

Elasticsearch version: 6.0.0 BC1

Server OS version: darwin_x86_64

Browser version: Chrome latest

Browser OS version: OS X

Original Kibana install method (e.g. download page, yum, from source, etc.): from staging

Original X-Pack install method (e.g. by name, offline install, from source, etc.): from staging

Description of the problem including expected versus actual behavior: If user prints csv report on empty results right now- Kibana just prints an empty CSV. User will have to download the csv to realize that it's empty.

Logging this here after discussing it with @kobelb so he can figure out how to handle it.

Steps to reproduce:

  1. Open a indexpattern in discover with no results
  2. save it and print a report
  3. Download the csv - its empty

Example report:
LINK REDACTED

@elasticmachine
Copy link
Contributor Author

Original comment by @kobelb:

@bhavyarm I removed the bug label since it's technically worked as designed right now, but we could definitely improve on this experience.

@elasticmachine elasticmachine added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead good first issue low hanging fruit labels Apr 25, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 13, 2018
@kertal
Copy link
Member

kertal commented Jan 26, 2019

To improve the user experience the number of rows a report contains should be displayed. Additionally I think the size of the report would also be helpful. I've added a rows field in the createGenerateCsv function, and with some more adaptions I've got a result, that i've wanted to share and discuss, before i'll continue implementing this approach

bildschirmfoto 2019-01-26 um 11 00 48

If the number is 0 the download button should be disabled. So, what do you think?

@kertal kertal self-assigned this Apr 4, 2019
@timroes timroes added Team:Stack Services and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 18, 2019
@kertal kertal removed their assignment Jul 29, 2019
@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@bmcconaghy bmcconaghy added Team:Reporting Services and removed Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 20, 2019
@elasticmachine
Copy link
Contributor Author

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor Author

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan
Copy link
Member

experience the number of rows a report contains should be displayed

Great idea! Working on this in #88303

@tsullivan
Copy link
Member

If the number is 0 the download button should be disabled. So, what do you think?

I think the behavior has changed quite a bit since this bug was filed. Today, an empty CSV still contains the search fields as header names, and I think that is useful.

@kertal
Copy link
Member

kertal commented Feb 2, 2021

@tsullivan yes, if somebody want's to download suche a CSV, it should be possible (BTW. this was the last issue I kind of contributed to before the elastic recruiter called me, maybe he was missing that feature 😄 )

@tsullivan
Copy link
Member

#88303 adds logging about the number of rows are generated from the data, which I think is adequate.

@tsullivan tsullivan added Team:Reporting Services enhancement New value added to drive a business result labels Feb 25, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels May 13, 2021
@tsullivan
Copy link
Member

Closing this since we add the column headers to the CSV (if they are defined in the job params, and are not just *), and we log how much data is created in the job during execution.

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 1, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Dec 9, 2021
@sophiec20 sophiec20 added Feature:Reporting:CSV Reporting issues pertaining to CSV file export and removed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Reporting:CSV Reporting issues pertaining to CSV file export good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label
Projects
None yet
Development

No branches or pull requests

7 participants