Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAM] Introduce API in asset_manager plugin to return service assets #182850

Closed
2 tasks
kpatticha opened this issue May 7, 2024 · 3 comments
Closed
2 tasks

[OAM] Introduce API in asset_manager plugin to return service assets #182850

kpatticha opened this issue May 7, 2024 · 3 comments
Labels
stale Used to mark issues that were closed for being stale Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@kpatticha
Copy link
Contributor

kpatticha commented May 7, 2024

Context

In the first iteration, we retrieved the assets within APM but the assets should be retrieved by a central plugin and not within every plugin.

The asset_manager seems the right place to expose the API related to assets. While the asset_manager already expose APIs, they are not used anywhere so probably it should be fine to clean up the existing code and introduce a simpler API

Requirements

Introduce a getServices(start, end, kuery) service that returns the service assets from the assets indices

Consumer:

  • APM

and it expects the minimum required fields to be

most likely we'll need agent.name

{
  "services": [
    {
      "asset": {
        "signalTypes": {
          "asset.traces": true,
          "asset.logs": true
        },
        "identifyingMetadata": [
          "service.name"
        ]
      },
      "service": {
        "name": "multisignal-service",
        "environment": "testing"
      }
    }
  ]
}

Query used in APM - https://github.com/elastic/kibana/pull/181842/files#diff-2f7f5edd98cf9152857697cb525eeb2765db8295de3efc9bcbaff602fb14063aR1

Pending

  • UI relies onagent.name to display the agent icon.

stretch goal

  • Use ES|QL to fetch the service assets

Note

  • minimum required field could change as we finalise OAM
@botelastic botelastic bot added the needs-team Issues missing a team label label May 7, 2024
@kpatticha kpatticha removed the needs-team Issues missing a team label label May 7, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label May 7, 2024
@kpatticha kpatticha added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team and removed needs-team Issues missing a team label labels May 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic
Copy link

botelastic bot commented Nov 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Nov 3, 2024
@cauemarcondes
Copy link
Contributor

This is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark issues that were closed for being stale Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

No branches or pull requests

3 participants