Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAILS ON MKI] Serverless Observability API Integration Tests - Common Group 1 x-pack/test_serverless/api_integration/test_suites/common/index_management/datastreams.ts #182647

Closed
wayneseymour opened this issue May 6, 2024 · 4 comments
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@wayneseymour
Copy link
Member

Serverless Security API Integration Tests - Common Group 1.x-pack/test_serverless/api_integration/test_suites/common/index_management/datastreams·ts

Index Management APIs Data streams Update sets data retention to infinite

Introduced 5 months ago in: #171926

Error message

Error: expected { success: true,
  warning: 'Not providing a retention is not allowed for this project. The default retention of [365d] will be applied.' } to sort of equal { success: true }
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at Context. (datastreams.ts:204:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:73:16) {
  actual: '{\n' +
    '  "success": true\n' +
    '  "warning": "Not providing a retention is not allowed for this project. The default retention of [365d] will be applied."\n' +
    '}',
  expected: '{\n  "success": true\n}',
  showDiff: true
}

Notes

I suspect something has changed on the back end and now this is failing consistently on MKI.

@wayneseymour wayneseymour added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels May 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@lukeelmers
Copy link
Member

@wayneseymour @sabarasaba I just stumbled across this linked PR: #182648

Does that skip the test, or fix it and address this issue?

The PR said test was skipped, but the implementation doesn't look like a skip, so just wanted to double check

@wayneseymour wayneseymour added blocker failed-test A test failure on a tracked branch, potentially flaky-test labels May 24, 2024
@wayneseymour wayneseymour changed the title fails on mki: Serverless Observability API Integration Tests - Common Group 1 x-pack/test_serverless/api_integration/test_suites/common/index_management/datastreams.ts [FAILS ON MKI] Serverless Observability API Integration Tests - Common Group 1 x-pack/test_serverless/api_integration/test_suites/common/index_management/datastreams.ts May 24, 2024
@alisonelizabeth
Copy link
Contributor

@sabarasaba can you investigate this and see if it's still valid? Thanks!

@sabarasaba
Copy link
Member

Seems the PR description wasnt updated, but this issue has been addressed by that pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

6 participants