Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Should this promise be retried? #182287

Open
Tracked by #182291
afharo opened this issue May 1, 2024 · 2 comments
Open
Tracked by #182291

[Synthetics] Should this promise be retried? #182287

afharo opened this issue May 1, 2024 · 2 comments
Labels
Synthetics Team:obs-ux-management Observability Management User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@afharo
Copy link
Member

afharo commented May 1, 2024

The promises below might fail in case there's a glitch in ES connection and never retry.

this.syntheticsService.setup(plugins.taskManager).catch(() => {});

this.telemetryEventsSender.start(pluginsStart.telemetry, coreStart).catch(() => {});

defaultAlertService
.setupDefaultAlerts()
.then(() => {
server.logger.debug(`Successfully created default alert for monitor: ${name}`);
})
.catch((error) => {
server.logger.error(`Error creating default alert: ${error} for monitor: ${name}`);
});

Is that OK? Should we apply any retry logic?

If we want to retry, p-retry could be a useful utility that's already present in the project.

@afharo afharo added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label May 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith added Synthetics technical debt Improvement of the software architecture and operational architecture labels May 2, 2024
@smith smith added Team:obs-ux-management Observability Management User Experience Team and removed Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Synthetics Team:obs-ux-management Observability Management User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants