-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] All the fields for all indices show when trying to add the a filters in a rule #179468
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
Seems to be fixed by #178207, but keeping it open for the team to confirm. |
Hi @jsanz , Is there any chance this problem can be resolved with index pattern and not with data view? |
Hey @shayfeld, can you provide more details/examples about ?
|
As you can see in the link of create new rule, using Index patterns: winlogbeat-* as source of the rule. In 178207 they are using Data View as a source. |
Hi @jsanz @nkhristinin @yctercero , In v8.13.4, the bug still exists. I sent a video to the support team. |
Thanks so much @shayfeld ! This is on our radar. We'll update the ticket as soon as we are able to take it up. |
I tried to reproduce the issue in 8.13.4, following the instructions in the ticket, but could not. Issue reproduced in 8.12.2Screen.Recording.2024-10-01.at.10.17.19.movIssue NOT reproduced in 8.13.4Screen.Recording.2024-10-01.at.10.19.18.movWhat are the steps to reproduce it in 8.13.4? Is something missing in my approach? |
If you'd like, I can schedule a Zoom meeting for tomorrow to show you the steps I took.
|
So, I was able to reproduce the issue. It does, in fact, fixed for indices, as in original ticket's description. |
…r all indices when trying to edit filters in a rule (#194678) ## Summary - addresses #179468 - fixes issue when rule configured with Data view **Steps to reproduce:** 1. Create a minimal new index and corresponding data view ```JSON PUT fields_index PUT fields_index/_mapping { "properties": { "@timestamp": { "type": "date" }, "field-1": { "type": "keyword" }, "field-2": { "type": "keyword" }, "field-3": { "type": "keyword" } } } POST fields_index/_doc { "@timestamp": "2024-10-01T09:26:30.425Z", "field-1": "test-0" } ``` 2. Create a security rule with that data view 3. Edit the rule and try to add a filter 4. Fields for all indices show up instead of the fields from the rule index 5. Switching to indices and back to data view on rule form fixes issue <details> <summary>video with the bug</summary> https://github.com/user-attachments/assets/fc83356d-d727-4662-856e-a4f0b386b71f </details> ### Additional benefit of fixing the issue. Previously, there would be 2 additional field_caps requests, querying ALL indices in ES, when rule edit page loads and rule configured with data view. ``` http://localhost:5601/kbn/internal/data_views/fields?pattern=&meta_fields=_source&meta_fields=_id&meta_fields=_index&meta_fields=_score&meta_fields=_ignored&allow_no_index=true&apiVersion=1 ``` Notice, there is `pattern=` query value, which results in querying all existing indices Now, these requests eliminated. #### Before <img width="2551" alt="Screenshot 2024-10-02 at 18 21 04" src="https://github.com/user-attachments/assets/aa2b6acb-897d-488f-9ddd-409379c6b54a"> #### After <img width="2557" alt="Screenshot 2024-10-02 at 18 22 41" src="https://github.com/user-attachments/assets/baeeecda-bf16-4d37-ae07-3cdc136d18b4">
…r all indices when trying to edit filters in a rule (elastic#194678) ## Summary - addresses elastic#179468 - fixes issue when rule configured with Data view **Steps to reproduce:** 1. Create a minimal new index and corresponding data view ```JSON PUT fields_index PUT fields_index/_mapping { "properties": { "@timestamp": { "type": "date" }, "field-1": { "type": "keyword" }, "field-2": { "type": "keyword" }, "field-3": { "type": "keyword" } } } POST fields_index/_doc { "@timestamp": "2024-10-01T09:26:30.425Z", "field-1": "test-0" } ``` 2. Create a security rule with that data view 3. Edit the rule and try to add a filter 4. Fields for all indices show up instead of the fields from the rule index 5. Switching to indices and back to data view on rule form fixes issue <details> <summary>video with the bug</summary> https://github.com/user-attachments/assets/fc83356d-d727-4662-856e-a4f0b386b71f </details> ### Additional benefit of fixing the issue. Previously, there would be 2 additional field_caps requests, querying ALL indices in ES, when rule edit page loads and rule configured with data view. ``` http://localhost:5601/kbn/internal/data_views/fields?pattern=&meta_fields=_source&meta_fields=_id&meta_fields=_index&meta_fields=_score&meta_fields=_ignored&allow_no_index=true&apiVersion=1 ``` Notice, there is `pattern=` query value, which results in querying all existing indices Now, these requests eliminated. #### Before <img width="2551" alt="Screenshot 2024-10-02 at 18 21 04" src="https://github.com/user-attachments/assets/aa2b6acb-897d-488f-9ddd-409379c6b54a"> #### After <img width="2557" alt="Screenshot 2024-10-02 at 18 22 41" src="https://github.com/user-attachments/assets/baeeecda-bf16-4d37-ae07-3cdc136d18b4"> (cherry picked from commit 5a71d84)
fixed in #194678 |
…r all indices when trying to edit filters in a rule (elastic#194678) ## Summary - addresses elastic#179468 - fixes issue when rule configured with Data view **Steps to reproduce:** 1. Create a minimal new index and corresponding data view ```JSON PUT fields_index PUT fields_index/_mapping { "properties": { "@timestamp": { "type": "date" }, "field-1": { "type": "keyword" }, "field-2": { "type": "keyword" }, "field-3": { "type": "keyword" } } } POST fields_index/_doc { "@timestamp": "2024-10-01T09:26:30.425Z", "field-1": "test-0" } ``` 2. Create a security rule with that data view 3. Edit the rule and try to add a filter 4. Fields for all indices show up instead of the fields from the rule index 5. Switching to indices and back to data view on rule form fixes issue <details> <summary>video with the bug</summary> https://github.com/user-attachments/assets/fc83356d-d727-4662-856e-a4f0b386b71f </details> ### Additional benefit of fixing the issue. Previously, there would be 2 additional field_caps requests, querying ALL indices in ES, when rule edit page loads and rule configured with data view. ``` http://localhost:5601/kbn/internal/data_views/fields?pattern=&meta_fields=_source&meta_fields=_id&meta_fields=_index&meta_fields=_score&meta_fields=_ignored&allow_no_index=true&apiVersion=1 ``` Notice, there is `pattern=` query value, which results in querying all existing indices Now, these requests eliminated. #### Before <img width="2551" alt="Screenshot 2024-10-02 at 18 21 04" src="https://github.com/user-attachments/assets/aa2b6acb-897d-488f-9ddd-409379c6b54a"> #### After <img width="2557" alt="Screenshot 2024-10-02 at 18 22 41" src="https://github.com/user-attachments/assets/baeeecda-bf16-4d37-ae07-3cdc136d18b4"> (cherry picked from commit 5a71d84)
@pborgonovi 8.15.3 BC has been built already, please validate the fix and keep the ticket open until is validated in 8.16.0 BC, thanks! |
looks like this fix did not make to 8.15.3, despite PR being labeled as 8.15.3 by Kibana bot. |
Thanks for the analysis @vitaliidm I'll make sure to validate 8.15.4 and 8.16 BC |
Issue is fixed in 8.16. Screen.Recording.2024-10-18.at.9.31.10.AM.movWaiting to validate with 8.15.4 |
Validated with 8.15.4 BC and fix looks good. Creating new rule: Screen.Recording.2024-11-05.at.2.38.33.PM.movUpdating a rule: Screen.Recording.2024-11-05.at.2.39.49.PM.mov |
Kibana version:
8.12.2
Original install method:
Cloud
Describe the bug:
When editing a security rule, the UI in the filter pill does not honor the index(es) that define the rule.
Steps to reproduce: (Original issue with index patterns, fixed in 8.13)
Re-adding the index forces makes the UI to refresh and get just the fields from the defined index.
video with the index pattern bug
vokoscreenNG-2024-03-26_17-52-47.mp4
Steps to reproduce: (Issue with data views, present in 8.15)
video with the Data view bug
Screen.Recording.2024-10-03.at.10.57.05.mov
Expected behavior:
Only the index/data view defined in the rule drives the fields showing up in the filter UI.
Screenshots (if relevant):
Errors in browser console (if relevant):
Nothing shows up
The text was updated successfully, but these errors were encountered: