Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AXE-CORE][Serverless - Observability] Observability ->Get started page - ai assistant button on top nav bar is failing "Buttons must have discernible text a11y check" #179195

Closed
bhavyarm opened this issue Mar 21, 2024 · 2 comments · Fixed by #179718
Closed

[AXE-CORE][Serverless - Observability] Observability ->Get started page - ai assistant button on top nav bar is failing "Buttons must have discernible text a11y check" #179195

bhavyarm opened this issue Mar 21, 2024 · 2 comments · Fixed by #179718
Assignees
@CoenWarmer
Labels
bug Fixes for quality problems that affect the customer experience obs-accessibilty A11Y issues in the Obs. solution. Team:obs-knowledge Observability Experience Knowledge team

Comments

@bhavyarm
Copy link
Contributor

Kibana version: main

Browser version: Chrome latest

Describe the bug: The button to access ai assistant in the top nav bar is failing " Buttons must have discernible text" a11y check.

Element location:

<div data-test-subj="kbnRedirectAppLink" class="css-h42ud6"><button type="button" class="euiButton css-19vmo7i-euiButtonDisplay-s-base-primary" data-test-subj="observabilityAiAssistantAppNavControlButton"><span class="css-1bascr2-euiButtonDisplayContent"><svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 64 64" fill="none" class="css-0"><path fill="#F04E98" d="M36 28h24v36H36V28Z"></path><path fill="#00BFB3" d="M4 46c0-9.941 8.059-18 18-18h6v36h-6c-9.941 0-18-8.059-18-18Z"></path><path fill="#343741" d="M60 12c0 6.627-5.373 12-12 12s-12-5.373-12-12S41.373 0 48 0s12 5.373 12 12Z"></path><path fill="#FA744E" d="M6 23C6 10.85 15.85 1 28 1v22H6Z"></path></svg></span></button></div>

This is the success criterion to meet this check.

Screenshot 2024-03-21 at 3 25 53 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Observability Team label for Observability Team (for things that are handled across all of observability) labels Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@smith smith added the Team:obs-knowledge Observability Experience Knowledge team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@smith smith removed the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Mar 21, 2024
@CoenWarmer CoenWarmer mentioned this issue Mar 29, 2024
Merged
CoenWarmer added a commit that referenced this issue Apr 2, 2024
@CoenWarmer
[AI Assistant for Observability] Add aria-label to AI Assistant button (
0f2599c 
#179718)

Resolves #179195

## Summary

Adds an `aria-label` for the AI Assistant for Observability button.
@smith smith added the obs-accessibilty A11Y issues in the Obs. solution. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoenWarmer CoenWarmer

Labels
bug Fixes for quality problems that affect the customer experience obs-accessibilty A11Y issues in the Obs. solution. Team:obs-knowledge Observability Experience Knowledge team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AI Assistant for Observability] Add aria-label to AI Assistant button CoenWarmer/kibana
4 participants
@smith @CoenWarmer @bhavyarm @elasticmachine