Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Embeddables rebuild #178375

Closed
9 tasks done
peteharverson opened this issue Mar 11, 2024 · 2 comments
Closed
9 tasks done

[ML] Embeddables rebuild #178375

peteharverson opened this issue Mar 11, 2024 · 2 comments
Assignees
@darnautov @alvarezmelissa87 @qn895
Labels
epic Feature:Anomaly Detection ML anomaly detection Feature:File and Index Data Viz ML file and index data visualizer Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis Meta :ml v8.15.0

Comments

@peteharverson
Copy link
Contributor

peteharverson commented Mar 11, 2024 •
edited
Loading

Meta issue to track progress on the rebuild of the embeddables the ML team owns.

Kibana’s Embeddables system is responsible for much of the behavior we see in Kibana today. Our Embeddable infrastructure underpins: Dashboards & Portable Dashboards, the Save and Return flow, drilldowns, Triggers & Actions, Portable Lens and Maps in solutions, the New Controls, much of Canvas, and a lot more.

This system is fundamental to Kibana, but is not well-liked by the engineers who maintain it, or adopt it. This is because it is over-engineered, boilerplate heavy and prescriptive. The Presentation team is planning to:

  • Build a new Embeddables system with the goal of making it adhere to well-known modern React paradigms.
  • Rework each of the 15 existing Embeddable implementations to use the new system
  • Completely remove the old Embeddables system from Kibana.

The ML team will be responsible for refactoring each of the embeddables that the team owns:

Embeddable rebuild tasks
Preview Give feedback
  1. [Embeddables Rebuild] Migrate Anomaly Swim Lane #174967
    4 of 4
    :ml Feature:Embeddables Team:Presentation impact:critical loe:medium project:embeddableRebuild v8.14.0
    darnautov
  2. [Embeddables Rebuild] Migrate Anomaly Chart #174966
    :ml Feature:Embeddables Team:Presentation impact:critical loe:medium project:embeddableRebuild v8.15.0
    qn895
  3. [Embeddables Rebuild] Migrate Single Metric Viewer #178130
    :ml Feature:Embeddables Team:ML Team:Presentation impact:critical loe:medium project:embeddableRebuild v8.15.0
    alvarezmelissa87
  4. [Embeddables Rebuild] Migrate Change Point Chart #174963
    :ml Feature:Embeddables Team:Presentation impact:critical loe:medium project:embeddableRebuild v8.15.0
    darnautov
  5. [Embeddables Rebuild] Migrate Data Visualizer Grid #174965
    :ml Feature:Embeddables Team:Presentation impact:critical loe:medium project:embeddableRebuild v8.15.0
    qn895

UX improvements
Preview Give feedback
  1. [ML] Single metric viewer embeddable - Add panel UX improvements #182042
    4 of 6
    :ml Feature:Anomaly Detection Team:ML v8.16.0
    alvarezmelissa87 joana-cps
@peteharverson peteharverson added Meta :ml Feature:Anomaly Detection ML anomaly detection Feature:File and Index Data Viz ML file and index data visualizer Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.14.0 labels Mar 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this issue Mar 18, 2024
Merged
darnautov added a commit that referenced this issue Mar 19, 2024
@darnautov
[ML] Decouple open-in-anomaly-explorer action (#178729)
a9968cb 
## Summary

Decouples open-in-anomaly-explorer UI action from embeddable framework.

- Modifies and exports helper utils from the embeddable plugin to
convert embeddable inputs and outputs to APIs
- Updates anomaly swim lane and anomaly charts embeddables to expose
required API for the "Open in Anomaly Explorer" action

Part of #178375
@darnautov darnautov mentioned this issue Mar 20, 2024
Merged
darnautov added a commit that referenced this issue Mar 22, 2024
@darnautov
[ML] Decouple edit-anomaly-swimlane UI action (#179073)
917f854 
## Summary

- Decouples edit-anomaly-swimlane and apply-time-range-selection UI
actions from embeddable framework

Part of #178375
Part of #174967
@arisonl arisonl added the epic label Apr 25, 2024
@darnautov darnautov mentioned this issue May 3, 2024
Merged
8 tasks
darnautov added a commit that referenced this issue May 8, 2024
@darnautov
[ML] Anomaly swim lane - add / edit UX improvements (#182586)
e9c3164 
## Summary

Part of #178375

- Updates the anomaly swim lane add / edit flow with a single flyout. 
- Replaces custom edit action with the default one 
- Improves error handling, preventing an observable from completion on
HTTP error

<img width="1356" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/10c55c86-1885-468f-988d-8d848fc7bd13">


### Checklist

- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@peteharverson
Copy link
Contributor Author

Closing as all items have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darnautov darnautov

@alvarezmelissa87 alvarezmelissa87

@qn895 qn895

Labels
epic Feature:Anomaly Detection ML anomaly detection Feature:File and Index Data Viz ML file and index data visualizer Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis Meta :ml v8.15.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@darnautov @arisonl @alvarezmelissa87 @peteharverson @elasticmachine @qn895