Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Prevent creation of rules with the same rule_id when importing rules concurrently #177283

Open
Tracked by #179907
maximpn opened this issue Feb 20, 2024 · 4 comments
Open
Tracked by #179907

[Security Solution] Prevent creation of rules with the same rule_id when importing rules concurrently #177283

maximpn opened this issue Feb 20, 2024 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Import/Export Security Solution Detection Rule Import & Export workflow impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@maximpn
Copy link
Contributor

maximpn commented Feb 20, 2024 •
edited by banderror
Loading

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #174168

Summary

Under some circumstances two users may import the same rules simultaneously. Current rules import implementation doesn't have a protection against concurrently creating multiple rules with the same rule_id.

The solution should prevent creating multiple rules with the same rule_id event when it's done concurrently.
@maximpn maximpn added bug Fixes for quality problems that affect the customer experience Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Feature:Rule Import/Export Security Solution Detection Rule Import & Export workflow labels Feb 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@maximpn maximpn added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 20, 2024
@thejwuscript
Copy link
Contributor

Hi @maximpn, I'm interested in working on this issue.

@banderror banderror mentioned this issue Apr 4, 2024
Open
@thejwuscript thejwuscript mentioned this issue Apr 10, 2024
Draft
4 tasks
@banderror banderror added 8.14 candidate and removed Feature:Rule Management Security Solution Detection Rule Management area labels Apr 11, 2024
@banderror banderror mentioned this issue Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Import/Export Security Solution Detection Rule Import & Export workflow impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maximpn @jpdjere @banderror @elasticmachine @thejwuscript