-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Change Refresh button in data visualizer and data drift view to indicate an update is pending #176737
Closed
3 tasks done
Labels
enhancement
New value added to drive a business result
Feature:File and Index Data Viz
ML file and index data visualizer
:ml
v8.17.0
Comments
Pinging @elastic/ml-ui (:ml) |
peteharverson
changed the title
[ML] Change Refresh button to Update to indicate an update is pending
[ML] Change Refresh button in data visualizer and data drift view to update to indicate an update is pending
Apr 17, 2024
peteharverson
added
v8.17.0
Feature:File and Index Data Viz
ML file and index data visualizer
and removed
v8.16.0
labels
Oct 16, 2024
peteharverson
changed the title
[ML] Change Refresh button in data visualizer and data drift view to update to indicate an update is pending
[ML] Change Refresh button in data visualizer and data drift view to indicate an update is pending
Oct 16, 2024
rbrtj
added a commit
that referenced
this issue
Oct 18, 2024
…ft view to indicate an update is pending (#196537) ## Summary Updated the refresh button to indicate that an update is pending after a query change in `Data View` and `Data Drift`. For: [#176737](#176737) After: Data View: https://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa Data drift: https://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea
Done in: #196537 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 18, 2024
…ft view to indicate an update is pending (elastic#196537) ## Summary Updated the refresh button to indicate that an update is pending after a query change in `Data View` and `Data Drift`. For: [elastic#176737](elastic#176737) After: Data View: https://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa Data drift: https://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea (cherry picked from commit 33f8fdd)
kibanamachine
added a commit
that referenced
this issue
Oct 18, 2024
…ta Drift view to indicate an update is pending (#196537) (#196915) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Data visualizer: Change refresh button in Data View and Data Drift view to indicate an update is pending (#196537)](#196537) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T15:34:29Z","message":"[ML] Data visualizer: Change refresh button in Data View and Data Drift view to indicate an update is pending (#196537)\n\n## Summary\r\n\r\nUpdated the refresh button to indicate that an update is pending after a\r\nquery change in `Data View` and `Data Drift`.\r\nFor: [#176737](https://github.com/elastic/kibana/issues/176737)\r\nAfter:\r\nData View:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa\r\n\r\n\r\n\r\nData drift:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea","sha":"33f8fddc19df7c1f4625f962f7a60acfa8b3d7b1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File and Index Data Viz","v9.0.0","Team:ML","backport:version","v8.17.0"],"title":"[ML] Data visualizer: Change refresh button in Data View and Data Drift view to indicate an update is pending","number":196537,"url":"https://github.com/elastic/kibana/pull/196537","mergeCommit":{"message":"[ML] Data visualizer: Change refresh button in Data View and Data Drift view to indicate an update is pending (#196537)\n\n## Summary\r\n\r\nUpdated the refresh button to indicate that an update is pending after a\r\nquery change in `Data View` and `Data Drift`.\r\nFor: [#176737](https://github.com/elastic/kibana/issues/176737)\r\nAfter:\r\nData View:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa\r\n\r\n\r\n\r\nData drift:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea","sha":"33f8fddc19df7c1f4625f962f7a60acfa8b3d7b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196537","number":196537,"mergeCommit":{"message":"[ML] Data visualizer: Change refresh button in Data View and Data Drift view to indicate an update is pending (#196537)\n\n## Summary\r\n\r\nUpdated the refresh button to indicate that an update is pending after a\r\nquery change in `Data View` and `Data Drift`.\r\nFor: [#176737](https://github.com/elastic/kibana/issues/176737)\r\nAfter:\r\nData View:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/249e4266-957d-4642-9841-603e20213faa\r\n\r\n\r\n\r\nData drift:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/474ad1ec-87e3-4d4b-8f4b-026887f453ea","sha":"33f8fddc19df7c1f4625f962f7a60acfa8b3d7b1"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New value added to drive a business result
Feature:File and Index Data Viz
ML file and index data visualizer
:ml
v8.17.0
Describe the feature:
Currently, we use the refresh button to allow users to Refresh. It would be a great UX enhancement to change the state of the button from 'Refresh' to 'Update' to indicate that there's stale data that needs to be updated or that an update is pending.
An example from Discover that changes from Refresh to Update when either the selected time range or query changes:
Screen.Recording.2024-02-12.at.12.05.56.mov
This PR for the ES|QL data visualizer introduces additional props that can be passed to the
DatePickerWrapper
component to achieve this state change.Describe a specific use case for the feature:
Several places across ML-maintained plugins can benefit from this change:
The text was updated successfully, but these errors were encountered: