Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/all_cases - Severity form field renders #176336

Open
kibanamachine opened this issue Feb 6, 2024 · 18 comments · Fixed by #176589, #177597, #178370 or #180909
Open

Failing test: Jest Tests.x-pack/plugins/cases/public/components/all_cases - Severity form field renders #176336

kibanamachine opened this issue Feb 6, 2024 · 18 comments · Fixed by #176589, #177597, #178370 or #180909
Assignees
@adcoelho
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 6, 2024 •
edited
Loading

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at it (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/all_cases/severity_filter.test.tsx:29:3)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at Object.describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/all_cases/severity_filter.test.tsx:17:1)
    at Runtime._execModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1430:24)
    at Runtime._loadModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1013:12)
    at Runtime.requireModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:873:12)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-00b7ddff1d427c37/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 6, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 6, 2024
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Feb 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 6, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@cnasikas cnasikas added the Feature:Cases Cases feature label Feb 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Feb 8, 2024
@mistic
skip flaky suite (#176336)
c094f61
@mistic
Copy link
Member

mistic commented Feb 8, 2024

Skipped.

main: c094f61

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@adcoelho adcoelho self-assigned this Feb 9, 2024
@adcoelho adcoelho mentioned this issue Feb 9, 2024
Merged
adcoelho added a commit that referenced this issue Feb 12, 2024
@adcoelho
[Cases] Severity flaky test (#176589)
dc8a50f 
Fixes #176337
Fixes #176336

## Summary

The usual fix. Running 200 times now to see if it works.
@kibanamachine kibanamachine reopened this Feb 13, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Feb 13, 2024
@mistic
skip flaky suite (#176336)
207d844
@mistic
Copy link
Member

mistic commented Feb 13, 2024

Skipped.

main: 207d844

@js-jankisalvi js-jankisalvi mentioned this issue Mar 11, 2024
Merged
1 task
@kibanamachine kibanamachine reopened this Mar 12, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Mar 12, 2024
@mistic
skip flaky suite (#176336)
e6892c8
@mistic
Copy link
Member

mistic commented Mar 12, 2024

Skipped.

main: e6892c8

@adcoelho adcoelho mentioned this issue Apr 16, 2024
Merged
adcoelho added a commit that referenced this issue Apr 17, 2024
@adcoelho
[Cases] Fix failing test: Severity form field renders (#180909)
828dd55 
Fixes #176336

## Summary

The only thing I could find in the test was a bunch of unnecessary DOM
searches. This is one of the most expensive operations in tests so I:
1. Converted the 3 redundant
`findByTestId('options-filter-popover-button-severity')` into just 1.
2. Did a single `findAllByRole('option')` instead of a search for every
single value + a search for all to guarantee length was 4.

Locally the test duration was reduced from 300ms to 150+-. Let's see how
it behaves in the pipeline.
@kibanamachine kibanamachine reopened this Jul 8, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

jbudz added a commit that referenced this issue Jul 8, 2024
@jbudz
skip failing test suite (#176336)
d9c3300
@jbudz
Copy link
Member

jbudz commented Jul 8, 2024

We're seeing this fail on a few pull requests in addition to ^.

Skipped

main: d9c3300

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
6 participants
@adcoelho @jbudz @mistic @cnasikas @elasticmachine @kibanamachine