Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color mapping feature case-sensitivity #176076

Closed
cachedout opened this issue Feb 1, 2024 · 3 comments · Fixed by #175144
Closed

Color mapping feature case-sensitivity #176076

cachedout opened this issue Feb 1, 2024 · 3 comments · Fixed by #175144
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@cachedout
Copy link
Contributor

Kibana version:
8.12.0
Elasticsearch version:
8.12.0
Server OS version:
ESS
Browser version:
Brave
Browser OS version:
Mac OSX
Original install method (e.g. download page, yum, from source, etc.):
ESS deployment
Describe the bug:
In the case where you have two separate fields where they are only distinguished by case, the Color Mapping picker refuses to let you select the two cases. A screenshot below demonstrates this in action. Not the lack of an option for Strongly Disagree in the Color Mapping picker, despite it being shown in the chart to the left.

Screenshot 2024-02-01 at 15 33 37

Steps to reproduce:

  1. Create ES documents with two fields which are only distinguished by case.
  2. Attempt to create a visualization and use the Color Mapping feature to associate colors with the two fields.
  3. Note that only one field can be chosen.

Expected behavior:
See reproduction steps.
Screenshots (if relevant):
See in-line screenshot.
Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@cachedout cachedout added the bug Fixes for quality problems that affect the customer experience label Feb 1, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 1, 2024
@jsanz jsanz added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 2, 2024
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Feb 2, 2024
@stratoula
Copy link
Contributor

cc @markov00

@markov00
Copy link
Member

markov00 commented Feb 2, 2024

I have a fix for this here #175144 but even though I see how this is a logic issue in the code, I strongly believe that such a case should not be fixed here in the color mapping, instead, this should be fixed in the data itself (in the ingestion pipeline or a cleaning/preparation phase).
The reasons: if two terms only differ by their letter case, 99.9% of the time those two terms are semantically the same and they should be "aggregated" together. You can always color the two slices the same way, but their values are not summed together and an interaction over the chart can cause confusion and misinterpretation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants