Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: workers written instead of worker under agent performance tuning. #174113

Closed
amolnater-qasource opened this issue Jan 2, 2024 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Docs Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

amolnater-qasource commented Jan 2, 2024

Kibana Build details:

VERSION: 8.12.0 BC4
BUILD: 70016
COMMIT: c2fda4713eb89786cf07dba596f6d45136858fd5

Host OS: All

Preconditions:

  1. 8.12.0 BC4 Kibana cloud environment should be available.

Steps to reproduce:

  1. Navigate to Fleet Settings.
  2. Add Elasticsearch output> performance tuning.
  3. Observe workers available instead of reserved keyword: worker.

Screenshots:
image

image

Expected Result:
worker should be written instead of workers under agent performance tuning guide as the reserved keyword is worker.

Doc link:
https://www.elastic.co/guide/en/fleet/8.12/es-output-settings.html#es-output-settings-performance-tuning-settings

Feature:
#166870

@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience Team:Docs Team:Fleet Team label for Observability Data Collection Fleet team impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 2, 2024
@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@cmacknz
Copy link
Member

cmacknz commented Jan 2, 2024

Just confirming that worker is the correct word without the s: https://www.elastic.co/guide/en/beats/filebeat/current/elasticsearch-output.html#_worker

@kilfoyle
Copy link
Contributor

kilfoyle commented Jan 2, 2024

@amolnater-qasource Since Craig confirmed above that worker is the correct term, I think the documentation page is okay.

Screenshot 2024-01-02 at 12 49 21 PM

Instead, perhaps this issue should be transferred to the Fleet team to change the UI message from workers to worker?

Screenshot 2024-01-02 at 12 51 21 PM

@cmacknz cmacknz transferred this issue from elastic/ingest-docs Jan 2, 2024
@amolnater-qasource amolnater-qasource changed the title [Docs][Fleet]: worker written instead of workers under agent performance tuning guide. [Fleet]: workers written instead of worker under agent performance tuning. Jan 3, 2024
@amolnater-qasource
Copy link
Author

Thank for you for the update Team.
We have updated this issue as per the requirement.

@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Mar 17, 2024
@amolnater-qasource
Copy link
Author

amolnater-qasource commented Mar 20, 2024

Hi Team,

We have revalidated this issue on latest 8.13.0 BC5 kibana cloud environment and found it fixed now.

Observations:

  • worker is written instead of workers under agent performance tuning guide as per the reserved keyword.

Screenshot:
image

Build details:
VERSION: 8.13.0 BC5
BUILD: 72025
COMMIT: d04713a

Hence, we are closing and marking this issue as QA:Validated.
Thanks!!

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Docs Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants