Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security][Dashboard Enhancements] Clicking on CIS Section cell value with Compliance Score 100% gives out wrong query #173235

Closed
animehart opened this issue Dec 13, 2023 · 3 comments · Fixed by #177083
Assignees
Labels
8.14 candidate bug Fixes for quality problems that affect the customer experience csp: quick win cloud-security label: tagging issues which are relatively small in effort and lowered in priority good first issue low hanging fruit Team:Cloud Security Cloud Security team related

Comments

@animehart
Copy link
Contributor

Describe the bug:
Clicking on CIS Section cell that has Compliance score of 100%, redirects the user to Findings page with 1 Query, instead of having Result: Passed (because compliance score is 100%) it has Result:Failed

Steps to reproduce:

  1. Navigate to CSP Dashboard
  2. Click on any CIS Section that has Compliance score of 100%

Expected behavior:
It should return Result: Passed

Actual behavior:
query has Result: Failed instead
Screenshots (if relevant):
https://github.com/elastic/kibana/assets/8703149/70c5d51e-2763-4beb-8ae9-dbcdd9b6ae16

@animehart animehart added bug Fixes for quality problems that affect the customer experience Team:Cloud Security Cloud Security team related 8.12 candidate labels Dec 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kfirpeled
Copy link
Contributor

Moved to 8.13, not critical for this release

@kfirpeled kfirpeled added 8.14 candidate good first issue low hanging fruit csp: quick win cloud-security label: tagging issues which are relatively small in effort and lowered in priority and removed 8.13 candidate labels Jan 28, 2024
@Omolola-Akinleye Omolola-Akinleye self-assigned this Feb 15, 2024
@kfirpeled kfirpeled linked a pull request Mar 10, 2024 that will close this issue
@seanrathier
Copy link
Contributor

Verified and validated this works

Kibana: 8.14.0

Tested by running a Kibana Dev Tools script to update all failed Findings with type cloud-storage to passed

POST logs-cloud_security_posture.findings_latest-default/_update_by_query
{
  "query": {
    "term": {
      "resource.type": "cloud-storage"
    }
  },
  "script": {
    "source": "ctx._source.result.evaluation = 'passed'",
    "lang": "painless"
  }
}

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.14 candidate bug Fixes for quality problems that affect the customer experience csp: quick win cloud-security label: tagging issues which are relatively small in effort and lowered in priority good first issue low hanging fruit Team:Cloud Security Cloud Security team related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants