Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObsUX][Profiling, Infra] Display "No data found" message instead of empty components #173153

Closed
mykolaharmash opened this issue Dec 12, 2023 · 1 comment · Fixed by #173633
Closed
Assignees
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@mykolaharmash
Copy link
Contributor

mykolaharmash commented Dec 12, 2023

We display empty flamegraph and top functions table when there is no data for the date range. Instead we should show a message like "No data found".

Image

Image

@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 12, 2023
@mykolaharmash mykolaharmash added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 12, 2023
@mykolaharmash mykolaharmash self-assigned this Dec 18, 2023
mykolaharmash added a commit that referenced this issue Jan 3, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 3, 2024
…ofiling data (elastic#173633)

Closes elastic#173153

## Summary

Adds a message when there is no data for flamegraph or top functions.

https://github.com/elastic/kibana/assets/793851/2a6158ca-86d3-4b23-9807-dc177ce0361b
(cherry picked from commit 9215e17)
kibanamachine referenced this issue Jan 3, 2024
…en there is no profiling data (#173633) (#174163)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[ObsUX][Profiling, Infra] Show "No Data" messages when
there is no profiling data
(#173633)](#173633)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-03T13:13:09Z","message":"[ObsUX][Profiling,
Infra] Show \"No Data\" messages when there is no profiling data
(#173633)\n\nCloses
https://github.com/elastic/kibana/issues/173153\r\n\r\n##
Summary\r\n\r\nAdds a message when there is no data for flamegraph or
top
functions.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/793851/2a6158ca-86d3-4b23-9807-dc177ce0361b","sha":"9215e17cb7c9ce49e7b9347ea578ec363d50dd8e","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-infra_services","v8.13.0"],"title":"[ObsUX][Profiling,
Infra] Show \"No Data\" messages when there is no profiling
data","number":173633,"url":"https://github.com/elastic/kibana/pull/173633","mergeCommit":{"message":"[ObsUX][Profiling,
Infra] Show \"No Data\" messages when there is no profiling data
(#173633)\n\nCloses
https://github.com/elastic/kibana/issues/173153\r\n\r\n##
Summary\r\n\r\nAdds a message when there is no data for flamegraph or
top
functions.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/793851/2a6158ca-86d3-4b23-9807-dc177ce0361b","sha":"9215e17cb7c9ce49e7b9347ea578ec363d50dd8e"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173633","number":173633,"mergeCommit":{"message":"[ObsUX][Profiling,
Infra] Show \"No Data\" messages when there is no profiling data
(#173633)\n\nCloses
https://github.com/elastic/kibana/issues/173153\r\n\r\n##
Summary\r\n\r\nAdds a message when there is no data for flamegraph or
top
functions.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/793851/2a6158ca-86d3-4b23-9807-dc177ce0361b","sha":"9215e17cb7c9ce49e7b9347ea578ec363d50dd8e"}}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
2 participants