-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ObsUX][Profiling, Infra] Preserve selected date range when navigating to full Profiling #173152
Labels
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
mykolaharmash
added
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
and removed
needs-team
Issues missing a team label
labels
Dec 12, 2023
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
mykolaharmash
added a commit
that referenced
this issue
Dec 14, 2023
Closes #173158 Closes #173152 ## Summary Switches from a hardcoded URL in `<ProfilingLinks>` to Profiling locators exposed by `observability_shared`. Also made `<ProfilingLinks>` a bit more generic pure visual component. Had to add locators to `observability_shared` plugin start interface as Infra currently does not expose plugins setup interfaces to components. https://github.com/elastic/kibana/assets/793851/5a4df5e2-4305-4439-a831-c9ddc9b82a71
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 14, 2023
Closes elastic#173158 Closes elastic#173152 ## Summary Switches from a hardcoded URL in `<ProfilingLinks>` to Profiling locators exposed by `observability_shared`. Also made `<ProfilingLinks>` a bit more generic pure visual component. Had to add locators to `observability_shared` plugin start interface as Infra currently does not expose plugins setup interfaces to components. https://github.com/elastic/kibana/assets/793851/5a4df5e2-4305-4439-a831-c9ddc9b82a71 (cherry picked from commit 2865931)
kibanamachine
referenced
this issue
Dec 14, 2023
…) (#173352) # Backport This will backport the following commits from `main` to `8.12`: - [[ObsUX] Use Profiling locators instead of hardcoded URL (#173246)](#173246) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-14T08:21:11Z","message":"[ObsUX] Use Profiling locators instead of hardcoded URL (#173246)\n\nCloses https://github.com/elastic/kibana/issues/173158\r\nCloses https://github.com/elastic/kibana/issues/173152\r\n\r\n## Summary\r\n\r\nSwitches from a hardcoded URL in `<ProfilingLinks>` to Profiling\r\nlocators exposed by `observability_shared`. Also made `<ProfilingLinks>`\r\na bit more generic pure visual component.\r\n\r\nHad to add locators to `observability_shared` plugin start interface as\r\nInfra currently does not expose plugins setup interfaces to components.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/793851/5a4df5e2-4305-4439-a831-c9ddc9b82a71","sha":"286593102ec28f47d5d682b6ded284f222f80203","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-infra_services","Team:obs-ux-management","v8.13.0"],"number":173246,"url":"https://github.com/elastic/kibana/pull/173246","mergeCommit":{"message":"[ObsUX] Use Profiling locators instead of hardcoded URL (#173246)\n\nCloses https://github.com/elastic/kibana/issues/173158\r\nCloses https://github.com/elastic/kibana/issues/173152\r\n\r\n## Summary\r\n\r\nSwitches from a hardcoded URL in `<ProfilingLinks>` to Profiling\r\nlocators exposed by `observability_shared`. Also made `<ProfilingLinks>`\r\na bit more generic pure visual component.\r\n\r\nHad to add locators to `observability_shared` plugin start interface as\r\nInfra currently does not expose plugins setup interfaces to components.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/793851/5a4df5e2-4305-4439-a831-c9ddc9b82a71","sha":"286593102ec28f47d5d682b6ded284f222f80203"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173246","number":173246,"mergeCommit":{"message":"[ObsUX] Use Profiling locators instead of hardcoded URL (#173246)\n\nCloses https://github.com/elastic/kibana/issues/173158\r\nCloses https://github.com/elastic/kibana/issues/173152\r\n\r\n## Summary\r\n\r\nSwitches from a hardcoded URL in `<ProfilingLinks>` to Profiling\r\nlocators exposed by `observability_shared`. Also made `<ProfilingLinks>`\r\na bit more generic pure visual component.\r\n\r\nHad to add locators to `observability_shared` plugin start interface as\r\nInfra currently does not expose plugins setup interfaces to components.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/793851/5a4df5e2-4305-4439-a831-c9ddc9b82a71","sha":"286593102ec28f47d5d682b6ded284f222f80203"}}]}] BACKPORT--> Co-authored-by: Mykola Harmash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Link to the full Profiling app right now preserves only the host, it should keep the date range as well.
The text was updated successfully, but these errors were encountered: