Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Rule tags popover hides tags of prebuilt rules #173151

Open
banderror opened this issue Dec 12, 2023 · 4 comments
Open

[Security Solution] Rule tags popover hides tags of prebuilt rules #173151

banderror opened this issue Dec 12, 2023 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@banderror
Copy link
Contributor

Summary

Location: Rule Management page, Rules table.

This popover is too narrow and many of the tags of prebuilt rules are not fully visible:

Screenshot 2023-12-11 at 14 40 13

@ARWNightingale:

we should probably still have a max character count or width right. I think increasing it by around 30-40% would be a huge improvement.
@banderror banderror added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team labels Dec 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@spong
Copy link
Member

spong commented Dec 13, 2023 •
edited
Loading

FYI, there's been some core work around these popover widths from the viz team recently: #171573

Can use the @kbn-calculate-width-from-char-count package for getting a good width (up to the max that Alex mentioned), coupled with the new text truncation component where you can do middle word truncation, which is nice for these UI's since it lets you see the final portion of the field name.

Pretty sure some security fields will still max this out though, so nice to have a delayed hover tooltip or something so you can discern it from what appears to the be the exact same field below it 😅

@pborgonovi
Copy link
Contributor

Validated latest 8.15 BC:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
Security Bug Audit
Status: To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spong @banderror @elasticmachine @pborgonovi